Update Android followSymlinkInits to handle sizeAllocated #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcprux
requested review from
glessard,
lorentey and
milseman
as code owners
rauhul
reviewed
Dec 7, 2025
| #expect(symlinkStat.size < targetStat.size) | ||
|
|
||
| #if os(Android) | ||
| #expect(symlinkStat.sizeAllocated <= targetStat.sizeAllocated) |
Contributor
There was a problem hiding this comment.
I would expect a citation for this and potentially a documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followSymlinkInitsis failing on an Android emulator (API 28 and 35). See https://github.com/swift-android-sdk/swift-android-sdk-workflow-demo/actions/runs/20010192707/job/57378485958#step:22:1657 :I can also reproduce it locally with
skip android test.I believe this is a known limitation of symbolic links on Android.
Note that the Android CI in https://github.com/swiftlang/github-workflows only builds and doesn't (yet) test, so this wasn't caught in the checks that were added in #270.