Skip to content

[Runtime] Async bodies + swift-http-types adoption #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Sep 27, 2023
Merged

[Runtime] Async bodies + swift-http-types adoption #47

Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
fd47bd2
[WIP] Async body currency type
czechboy0 Sep 1, 2023
beca630
Rename Body to HTTPBody to avoid confusion with the generated Body enums
czechboy0 Sep 4, 2023
34f7c59
[WIP] Adopt swift-http-types
czechboy0 Sep 4, 2023
d046bf9
WIP
czechboy0 Sep 4, 2023
164f84e
wip
czechboy0 Sep 5, 2023
3db782e
Remove mapChunks, rename initializer parameters
czechboy0 Sep 5, 2023
6c97d48
wip
czechboy0 Sep 5, 2023
466b701
Remove String coder, fix up client unit tests
czechboy0 Sep 5, 2023
00ec189
Got the other tests working
czechboy0 Sep 5, 2023
fe08164
Just use Substring in more places
czechboy0 Sep 5, 2023
63f05d6
wip
czechboy0 Sep 6, 2023
982fe13
wip
czechboy0 Sep 6, 2023
1317631
Added more docs
czechboy0 Sep 6, 2023
faba5ce
Add back docs
czechboy0 Sep 6, 2023
6a71613
Improve loggability of the currency types
czechboy0 Sep 7, 2023
1c07795
Bring back comments on ServerError
czechboy0 Sep 7, 2023
2540b77
WIP
czechboy0 Sep 7, 2023
a165558
Add comments back
czechboy0 Sep 7, 2023
c4186f8
Prefix extensions on types we don't own
czechboy0 Sep 7, 2023
5e1d21e
WIP on documentation
czechboy0 Sep 7, 2023
0ee065f
Add docs for HTTPBody
czechboy0 Sep 7, 2023
99d8252
Add doc comments
czechboy0 Sep 7, 2023
d85eb55
More docs
czechboy0 Sep 7, 2023
844be3a
Merge branch 'main' into hd-adopt-http-types
czechboy0 Sep 7, 2023
1406537
Fixes
czechboy0 Sep 7, 2023
84361a8
Make iterator next() method mutating
czechboy0 Sep 8, 2023
9f10325
Represent no responses as a nil HTTPBody in server transport and midd…
czechboy0 Sep 8, 2023
dbda450
Feedback: make the AsyncSequences Sendable, which adds the requiremen…
czechboy0 Sep 12, 2023
fbe8eea
Feedback: further cleanup of the HTTPBody API
czechboy0 Sep 12, 2023
8b432b2
Remove unnecessary initializers
czechboy0 Sep 12, 2023
3f59f44
Review feedback:
czechboy0 Sep 13, 2023
16917ce
Review feedback: make response body optional
czechboy0 Sep 13, 2023
4830821
A few more changes
czechboy0 Sep 13, 2023
213addf
Wording and a refactor fix
czechboy0 Sep 14, 2023
a5e22b6
Merge branch 'main' into hd-adopt-http-types
czechboy0 Sep 18, 2023
c314914
Fix a few more missing sendable annotations
czechboy0 Sep 18, 2023
0cf76f2
Update docs
czechboy0 Sep 18, 2023
af10f7d
Update HTTPBody.swift
czechboy0 Sep 18, 2023
b2fb79e
Update HTTPBody.swift
czechboy0 Sep 18, 2023
1778209
Update HTTPBody.swift
czechboy0 Sep 18, 2023
b58a3b6
Update HTTPBody.swift
czechboy0 Sep 18, 2023
b2d4ec3
Update HTTPBody.swift
czechboy0 Sep 18, 2023
66b602f
Update HTTPBody.swift
czechboy0 Sep 18, 2023
b0ccaae
Update ServerTransport.swift
czechboy0 Sep 18, 2023
3f5b3d3
Merge remote-tracking branch 'apple/main' into hd-adopt-http-types
czechboy0 Sep 25, 2023
a129b6b
Fixing up the merge from main
czechboy0 Sep 25, 2023
a3516b7
Merge branch 'hd-adopt-http-types' of github.com:czechboy0/swift-open…
czechboy0 Sep 25, 2023
f5d8c1c
Merge branch 'main' into hd-adopt-http-types
czechboy0 Sep 25, 2023
a89bced
Use swift-http-types 1.0
czechboy0 Sep 25, 2023
b19a787
Provide a closure for accessing the locked value HTTPBody.iteratorCre…
czechboy0 Sep 25, 2023
481e6bb
Fix up encoding comment
czechboy0 Sep 25, 2023
dc209d3
Update Sources/OpenAPIRuntime/Interface/HTTPBody.swift
czechboy0 Sep 25, 2023
05082f9
Update Sources/OpenAPIRuntime/Conversion/CurrencyExtensions.swift
czechboy0 Sep 25, 2023
03a9f2d
Update Tests/OpenAPIRuntimeTests/Conversion/Test_Converter+Common.swift
czechboy0 Sep 26, 2023
ed46fa5
Explicitly test substring support
czechboy0 Sep 26, 2023
669a7f3
Add a test case with an unknown length
czechboy0 Sep 26, 2023
72d241d
PR feedback: improve the iteration behavior checking in HTTPBody, ren…
czechboy0 Sep 26, 2023
0704673
Added a test for the collect method based on a known length
czechboy0 Sep 26, 2023
492cf0c
Move extensions of http types into the generated SPI
czechboy0 Sep 26, 2023
24f8870
Update version in docs to 0.3.0
czechboy0 Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ServerTransport.swift 
Co-authored-by: Si Beaumont <simonjbeaumont@gmail.com>
  • Loading branch information
@czechboy0 @simonjbeaumont
czechboy0 and simonjbeaumont authored Sep 18, 2023
commit b0ccaae913cdf68b77057c296656372c5513ed9e
2 changes: 1 addition & 1 deletion Sources/OpenAPIRuntime/Interface/ServerTransport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public protocol ServerTransport {
/// - handler: A handler to be invoked when an HTTP request is received.
/// - method: An HTTP request method.
/// - path: A URL template for the path, for example `/pets/{petId}`.
/// - Important: The `path` can have mixed component, such
/// - Important: The `path` can have mixed components, such
/// as `/file/{name}.zip`.
func register(
_ handler: @Sendable @escaping (HTTPRequest, HTTPBody?, ServerRequestMetadata) async throws -> (
Expand Down