Update README.md #731
Merged
Update README.md #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue when starting Vapor in swift 6. I believe earlier versions of Swift throw a warning about this.
czechboy0
reviewed
Feb 7, 2025
Remove environment detection param
|
Thanks @bdiesel, I believe there are a few more places in the repo, could you grep for any other occurrences? The docc landing page might also have this example, possibly also tutorials and examples. Thanks! |
… with .make() for swift 6 compatibility
|
My pleasure! I've updated all the instances in the documentation. My original pr did not include the Vapor namespace so I've added that for consistency and clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when starting Vapor in swift 6. I believe earlier versions of Swift throw a warning about this.
Motivation
I was following along with documentations but Vapor was throwing an error: Initializer 'init' is unavailable from asynchronous contexts; This initialiser cannot be used in async contexts, use Application.make(::) instead
Modifications
Just a very simple update to the documentation so others getting started don't hit the same issue
Result
Vapor server will start when following docs.
Test Plan
manual tests.