Initial pass at pow(Self, Int) for Float and Double #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the hardest cases to get right; most of the fail at present. Also some improvements to sanityCheck to handle negative values correctly and treat infinity as the next binade up (which isn't ideal for general use, but is good for this sort of rough testing.)
We don't need to do anything special for Float80, but Float and Double require some handholding because Int values are not always representable.
Also skip out of tests that won't compile and wouldn't make sense anyway on 32b systems.
|
Very nice. It might be worth mentioning that the …or it might not be worth mentioning. |
|
On a hypothetical future platform where
So this is mostly theoretical. But I'll add a note anyway =) |
|
This change (without the note) is tagged as 0.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More clever implementation is certainly possible (and desired in the long-term), but this basically gets us to the desired semantics without undue performance penalty for the common use cases.