Add Augmented.sum(_:_:) aka "twoSum"
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuswntr
changed the title
Augmented.sum(_:_:) aka twoSumAugmented.sum(_:_:) aka "twoSum"
|
Mind adding a couple test cases? |
|
@swift-ci test |
xwu
reviewed
Oct 26, 2021
Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com>
|
@swift-ci test |
stephentyrone
approved these changes
Oct 27, 2021
|
I'll probably write some additional documentation for this down the road, but LGTM as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With augmented arithmetic in place, I was wondering if we might as well add "twoSum" alongside the existing "fast2sum".
https://en.wikipedia.org/wiki/2Sum
As with "fast2sum", which is currently used for the elementary function of complex numbers, "twoSum" would be useful for the elementary function of quaternions where, due the additional pair of imaginary numbers, the magnitudes of the summands can not be guaranteed to be in any order.