SelectorGeneric, SelectorKqueue, and NonBlockingFileIO successfully compile on FreeBSD#3588
Open
rafaelcepeda wants to merge 10 commits into
Open
SelectorGeneric, SelectorKqueue, and NonBlockingFileIO successfully compile on FreeBSD#3588rafaelcepeda wants to merge 10 commits into
SelectorGeneric, SelectorKqueue, and NonBlockingFileIO successfully compile on FreeBSD#3588rafaelcepeda wants to merge 10 commits into
Conversation
rafaelcepeda
changed the title
SelectorGeneric, SelectorKqueue, or NonBlockingFileIO successfully compile on FreeBSDSelectorGeneric, SelectorKqueue, and NonBlockingFileIO successfully compile on FreeBSD
rafaelcepeda
force-pushed
the
freebsd-nioposix
branch
from
May 12, 2026 12:40
8a5f119 to
ffae81c
Compare
gjcairo
reviewed
May 13, 2026
| ] | ||
| #else | ||
| let eventFilters: [(KQueueEventFilterSet, CInt)] = [ | ||
| (.read, CInt(EVFILT_READ)), (.write, CInt(EVFILT_WRITE)), |
Contributor
There was a problem hiding this comment.
Is it okay to not have the except filter here? Are we effectively changing some behaviour in an unexpected way?
| private let sysSendMmsg = CNIOLinux_sendmmsg | ||
| private let sysRecvMmsg = CNIOLinux_recvmmsg | ||
| #elseif os(FreeBSD) | ||
| private let sysKevent = kevent |
Contributor
There was a problem hiding this comment.
It's also potentially suspicious we're not defining any of the other lets here since we do for other platforms. What's the reason?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kqueue selector backend now works on FreeBSD,
EVFILT_EXCEPTis properly guarded for Darwin/OpenBSD only,d_filenois used on FreeBSD, andsysFstat/sysKevent/KQueueenum are enabled for FreeBSD.Motivation:
This is a small step towards making NIOPosix fully compile on FreeBSD.
Modifications:
Changed
SelectorGeneric,SelectorKqueue, andNonBlockingFileIOfiles to ensure they correctly compile on FreeBSD.Result:
Indicated files now compile with no errors on FreeBSD.