Adjust for SendableMetatype #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-fix-62-warnings
branch
from
f89177e to
b6777f3
Compare
FranzBusch
approved these changes
Jun 11, 2025
Motivation
With the introduction of isolated conformances, it has become
necessary to start managing the use of metatypes for some of
our protocols. In general, we don't want to force the relevant
protocols to only be conformed in non-isolated forms. Instead,
we just want to make the specific APIs non-usable.
Modifications
- Add shims for SendableMetatype that only use it when it is
available.
- Require SendableMetatype where needed, gated by @preconcurrency.
Result
We continue to be safe.
Lukasa
force-pushed
the
cb-fix-62-warnings
branch
from
0c99b0b to
7fa7b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the introduction of isolated conformances, it has become necessary to start managing the use of metatypes for some of our protocols. In general, we don't want to force the relevant protocols to only be conformed in non-isolated forms. Instead, we just want to make the specific APIs non-usable.
Modifications
Result
We continue to be safe.