prepare ci scripts #32
Conversation
| RUN update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-5.0 100 | ||
|
|
||
| # modern curl | ||
| #RUN apt-get install -y curl |
There was a problem hiding this comment.
remove ? Why do we need some special curl ?
There was a problem hiding this comment.
this is a good question for @weissi, as far as i can tell the integration tests require more modern curl with uds?
There was a problem hiding this comment.
@tomerd integration tests will work with any curl that does UDS.
There was a problem hiding this comment.
oh, we're basing this on Ubuntu 14.04. IIRC that curl does not do UDS...
There was a problem hiding this comment.
so I believe this is neccessary at the momen
docker/Dockerfile
Outdated
| RUN apt-get install -y libicu-dev libblocksruntime0 pkg-config | ||
| RUN apt-get install -y lsof dnsutils | ||
|
|
||
| RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add - |
There was a problem hiding this comment.
nit. whitespace before and after the pipe.
docker/Dockerfile
Outdated
|
|
||
| # script to allow mapping framepointers on linux | ||
| RUN mkdir -p $HOME/.scripts | ||
| RUN wget -q https://raw.githubusercontent.com/apple/swift/1e078fbdfa768e211e0473cf917511efd73aec86/utils/symbolicate-linux-fatal -O $HOME/.scripts/symbolicate-linux-fatal |
There was a problem hiding this comment.
nit: Should we just merge the script into our repo ?
There was a problem hiding this comment.
@weissi wdyt? i think its used elsewhere also?
Motivation: set up continuous integration Modifications: * update docker file to include all dependencies required for build, unit tests, integration tests and doc generation * remove dependency steps from doc generation script * add integration tests driver script Result: able to set up docker based continuous integration
Motivation: SMTP in 2019 uses STARTTLS, therefore NIOSMTP should support that too. I have also been asked multiple times if NIOSMTP supported STARTTLS. Modification: Support STARTTLS Result: Better example.
Motivation:
set up continuous integration
Modifications:
Result:
able to set up docker based continuous integration