Enable strict concurrency checking for NIOTLS #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
strict_concurrency_niotls
branch
from
143fc69 to
1104b21
Compare
Motivation: To preserve NIOTLS concurrency safety. Modifications: Enable strict concurrency checking in the package manifest. Result: Builds will warn and CI will fail if regressions are introduced.
In NIOTypedApplicationProtocolNegotiationHandler<NegotiationResult> the result is used to fulfil promises and perform hops so we need it to be sendable when accessed from these other concurrency domains.
rnro
force-pushed
the
strict_concurrency_niotls
branch
from
1104b21 to
06bc720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To ensure NIOTLS concurrency safety.
Modifications:
NegotiationResultto beSendableNIOTypedApplicationProtocolNegotiationHandler<NegotiationResult>theresult is used to fulfil promises and perform hops so we need it to be
sendable when accessed from these other concurrency domains.
Result:
Builds will warn and CI will fail if regressions are introduced.