Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve flatScheduleTask #3079

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Improve flatScheduleTask #3079

merged 3 commits into from
Jan 22, 2025

Conversation

clintonpi
Copy link
Contributor

@clintonpi clintonpi commented Jan 22, 2025 •
edited
Loading

Motivation:

As pointed out in #3071, the flatScheduleTask implementations can be improved.

Modifications:

  • Refactor the flatScheduleTask implementations to skip flatMap calls, which avoids creating an extra promise.
  • As there is now a lower number of allocations, reduce the necessary thresholds for the allocation tests.

Result:

Reduction in the number of allocations in the package.

@clintonpi
Improve flatScheduleTask
dc5742e 
Motivation:

As pointed out in apple#3071, the `flatScheduleTask` implementations can be improved.

Modifications:

- Refactor the `flatScheduleTask` implementations to skip `flatMap` calls, which avoids creating an extra promise.

Result:

Potential reduction in the number of allocations in the package.
@clintonpi
Reduce thresholds for allocation tests
4696bc8
glbrntt
glbrntt approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @clintonpi!

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 22, 2025
@glbrntt glbrntt linked an issue Jan 22, 2025 that may be closed by this pull request
Improve flatScheduleTask #3071
Closed
@glbrntt glbrntt enabled auto-merge (squash) January 22, 2025 16:02
@glbrntt glbrntt merged commit b14012b into apple:main Jan 22, 2025
33 of 35 checks passed
@clintonpi clintonpi deleted the flat-schedule-task-improvement branch January 22, 2025 16:43
@0xTim 0xTim mentioned this pull request Feb 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve flatScheduleTask
2 participants
@clintonpi @glbrntt