Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention NIOPosix in README. #1940

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Mention NIOPosix in README. #1940

merged 4 commits into from
Aug 17, 2021

Conversation

fabianfett
Copy link
Member

No description provided.

@fabianfett fabianfett requested review from Lukasa and glbrntt August 17, 2021 15:48
@Lukasa Lukasa added the semver/none No version bump required. label Aug 17, 2021
Lukasa
Lukasa reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that down in the Conceptual Overview section there are a few places that say things like "provided by NIO" that need to be updated.

@fabianfett fabianfett requested review from Lukasa and glbrntt August 17, 2021 16:05
glbrntt
glbrntt reviewed Aug 17, 2021
View reviewed changes
Lukasa
Lukasa approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fabianfett fabianfett merged commit 0f6a62a into main Aug 17, 2021
@fabianfett fabianfett deleted the fabianfett-patch-1 branch August 17, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @Lukasa @glbrntt