Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Swift 5.5 job #1845

Merged
merged 1 commit into from
Jun 1, 2021
Merged

add Swift 5.5 job #1845

merged 1 commit into from
Jun 1, 2021

Conversation

weissi
Copy link
Member

@weissi weissi commented May 4, 2021

No description provided.

@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2021

@swift-nio-bot test this please

@Lukasa Lukasa added the semver/none No version bump required. label May 5, 2021
@Lukasa
Copy link
Contributor

Lukasa commented May 5, 2021

There are no nightly 5.5 docker images at the moment. We need to either get them to come into existence or disable the 5.5 job until they do.

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the broken 5.5 job.

@yim-lee
Copy link
Member

yim-lee commented May 5, 2021

Disabled the 5.5. job

@finagolfin
Copy link
Contributor

I'm seeing problems compiling the tests with a recent official trunk snapshot build of the toolchain on linux:

> ~/src/swift-DEVELOPMENT-SNAPSHOT-2021-05-26-a-centos8/usr/bin/swift build --build-tests -j 2
/home/butta/swift-nio/Tests/NIOHTTP1Tests/TestUtils.swift:276:25: error: value of type 'sockaddr_in' has no member 'addressDescription'
            return addr.addressDescription()
                   ~~~~ ^~~~~~~~~~~~~~~~~~
/home/butta/swift-nio/Tests/NIOHTTP1Tests/TestUtils.swift:279:25: error: value of type 'sockaddr_in6' has no member 'addressDescription'
            return addr.addressDescription()
                   ~~~~ ^~~~~~~~~~~~~~~~~~

Swift 5.4 builds the exact same commit 43fa768 without a problem, so there appears to have been a regression somewhere.

@Lukasa
Copy link
Contributor

Lukasa commented May 29, 2021

This appears to be a compiler error, as that method is made available in an extension. Can you report this at bugs.swift.org?

@finagolfin
Copy link
Contributor

Sure.

@finagolfin
Copy link
Contributor

Looks like @weissi already reported it: SR-14268 and SR-14590.

@Lukasa
Copy link
Contributor

Lukasa commented Jun 1, 2021

@yim-lee I believe the 5.5 builds should be able to be turned back on with the subsequent changes made in this patch.

@yim-lee
Copy link
Member

yim-lee commented Jun 1, 2021

@swift-nio-bot test this please

@yim-lee
Copy link
Member

yim-lee commented Jun 1, 2021

The 5.5 job was enabled but didn't get triggered for some reason. Should be ok now.

@Lukasa Lukasa merged commit b23f40b into apple:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants