Skip to content

Don't use deadbeef for dead pointers. #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Don't use deadbeef for dead pointers. #1604

merged 1 commit into from
Jul 30, 2020

Conversation

PeterAdams-A
Copy link
Contributor

Motivation:

It turns out using this overflows Int on "Any iOS Device"

Modifications:

Switch the first d to a 7.

Result:

Code will compile on "Any iOS Device".

@PeterAdams-A
Don't use deadbeef for dead pointers.
0158ad0 
Motivation:

It turns out using this overflows Int on "Any iOS Device"

Modifications:

Switch the first d to a 7.

Result:

Code will compile on any iOS.
@PeterAdams-A
Copy link
Contributor Author

This should resolve #1603

glbrntt
glbrntt approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less amusing than 0xdeadbeef but looks good otherwise.

@PeterAdams-A PeterAdams-A added the 🔨 semver/patch No public API change. label Jul 30, 2020
@glbrntt glbrntt mentioned this pull request Jul 30, 2020
Closed
@PeterAdams-A
Copy link
Contributor Author

@swift-nio-bot test this please

@PeterAdams-A PeterAdams-A merged commit 496d697 into apple:master Jul 30, 2020
@ktoso
Copy link
Member

ktoso commented Jul 31, 2020 •
edited
Loading

lol, interesting :)
Are the iOS devices are vegetarian ¯\(ツ)/¯

@Lukasa
Copy link
Contributor

Lukasa commented Jul 31, 2020

Nah, sadly just the older ones have 32-bit pointers

@ktoso
Copy link
Member

ktoso commented Jul 31, 2020

Yeah, just making a silly beef joke, pardon me :)

slashmo pushed a commit to slashmo/swift-nio that referenced this pull request Aug 18, 2020
@PeterAdams-A @slashmo
Don't use deadbeef for dead pointers. (apple#1604)
5dde414 
Motivation:

It turns out using this overflows Int on "Any iOS Device"

Modifications:

Switch the first d to a 7.

Result:

Code will compile on "Any iOS Device".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeterAdams-A @ktoso @Lukasa @glbrntt