nicer way to use docker compose #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: asking to `cd` into the docker directory is not user firendly Modifications: use `docker-compose -f` directive Result: happier users
normanmaurer
requested changes
Mar 5, 2018
Package.swift-e
Outdated
| .package(url: "https://github.com/apple/swift-nio-zlib-support.git", from: "1.0.0"), | ||
| ], | ||
| targets: targets | ||
| ) |
normanmaurer
approved these changes
Mar 5, 2018
normanmaurer
approved these changes
Mar 5, 2018
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
) Motivation: As noted in apple#105, I spotted that we were heap-allocating an array when parsing the frame header. That heap allocation isn't necessary, we can just write directly into an Int, which should save us some heap spray. Modifications: - Rewrote code to avoid heap allocating array and instead to use Int. - Elided some bounds checks by using an unsafe pointer, since I was already here and it saved about 1% performance in a hot loop. Result: Fewer heap allocations on the hot code path.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
…ple#105) * Skip HTTPResponseCompressor logic if response is 204 (no content) * update test manifests * use mayHaveResponseBody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
asking to
cdinto the docker directory is not user firendlyModifications:
use
docker-compose -fdirectiveResult:
happier users