Add toDerBytes to SSLPrivateKey
#540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jun 13, 2025
Lukasa
reviewed
Jun 13, 2025
gjcairo
commented
Jun 13, 2025
Comment on lines
-81
to
-83
| /// While generally speaking type-erasure has some nasty performance problems, we only need the type-erasure for | ||
| /// Hashable conformance, which we don't use in any production code: only the tests use it. To that end, we don't | ||
| /// mind too much that we need to do this. |
There was a problem hiding this comment.
I modified this comment because I don't think this is true anymore: we are using the type-erased version in NIOSSLPrivateKey
Lukasa
reviewed
Jun 13, 2025
Lukasa
reviewed
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new API (
SSLPrivateKey/toDerBytes()) to get the DER bytes for a private key.This is only supported for native (EVP) keys; if using a custom key, an empty array of bytes will be returned instead.