-
Notifications
You must be signed in to change notification settings - Fork 72
doc updates - formatting, organization, and language #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Checking the sound-ness manually: swift package add-dependency https://github.com/swiftlang/swift-docc-plugin --from 1.0.0
swift package plugin generate-documentation --target "Metrics" --warnings-as-errors --analyze
swift package plugin generate-documentation --target "CoreMetrics" --warnings-as-errors --analyze
swift package plugin generate-documentation --target "MetricsTestKit" --warnings-as-errors --analyze On Swift 6.2, all are passing without issue, but something is crashing in the GitHub workflow test pipeline for docs soundness. |
Thanks Joe! The api breakage isn’t real because it’s about underscored symbols and we’re just hiding them from docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor notes
- added explicit curation for the major types - revised the language to writing guidelines - removed symbols in abstracts - spelled out symbols in abstracts - revised titles to single sentences - updated grammar to switch to present tense
Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
…ss the docs for consistency
I didn't add in the docs for the no-op handler, which depresses the coverage numbers a smidge, but most of the rest are in good shape in terms of just broad coverage and consistency:
|
(the @_documentation updates reflect as breaking API changes, even though the availability of the symbols themselves aren't changed)