Add support for Display String type to StructuredFieldValues #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The parser and serializer for the Display String type have been implemented. The high-level encoder and decoder should follow. Modifications: Implement the encoder and decoder for Display String. Result: The StructuredFieldValues module will support the Display String type.
Lukasa
reviewed
Nov 29, 2024
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// A type that represents the Display String Structured Type. | ||
| public struct DisplayString: Codable, Equatable { |
There was a problem hiding this comment.
Probably nicer to use RawRepresentable and set rawValue as String. There's no real need to have private(set) here anyway.
Also add Hashable conformance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The parser and serializer for the Display String type have been implemented. The high-level encoder and decoder should follow.
Modifications:
Implement the encoder and decoder for Display String.
Result:
The StructuredFieldValues module will support the Display String type.