Update for open-source Decimal fixes #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
cc @Lukasa |
|
@swift-server-bot add to allowlist |
Lukasa
requested changes
Jan 4, 2022
Sources/StructuredFieldValues/Encoder/StructuredFieldValueEncoder.swift
Outdated
Show resolved
Hide resolved
Sources/StructuredFieldValues/Encoder/StructuredFieldValueEncoder.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory Benfield <lukasa@apple.com>
|
Thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minimal changes to ensure cross-platform and future-proof usage of
Foundation.DecimalAPIs that have incorporated various fixes on Linux that may or may not be incorporated in future Apple releases also.In brief, we'll always take the magnitude (absolute value) of the value that's returned from
Decimal.significandand always in turn provide a positive significand toDecimal.init(sign:exponent:significand:).Works around SR-15132.