You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SocketAddress is the types of addresses that socket can connect to, and I wonder if that should be a concurrency since it's specific to the socket API. Also port should probably be separate from IP since it's specific to TCP and UDP.
Also port should probably be separate from IP since it's specific to TCP and UDP.
I agree with this though. Port should only come into play with SocketAddress or an Endpoint type and not IPAddress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need some concept of a socket (IPv4/IPv6) address.
Solves #41
Modifications
This type already existed in swift-http-server, but we want to centralise all currency types in their own module, so moving that type here.