Open
Conversation
If a Content-Length header exists for a 204 or 304 response, it should be ignored.
…ngth Also renamed withBadHTTPServer -> withRawHTTPServer because some of the responses are valid, but just hard to construct with the official HTTP Server.
The RFC spec says that a recipient MAY recognize a single LF as a line terminator and ignore any preceding CR. It's optional and AHC doesn't do that.
guoye-zhang
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A raw HTTP server (built directly on top of sockets) allows us to create unusual, possibly malformed HTTP/1.1 responses and test our HTTP clients for conformance against those.
Use RFC 9112 as inspiration for these test cases.
Modifications
withRawHTTPServerthat constructs a raw HTTP server with some predefined endpoints.RawServerConformanceTestssuiteResult
These tests are also run under presubmit. URLSession passes this test suite.
Test Plan
Manually verified some of this behavior with
curland Wireshark.