feat: Add Swift WebAssembly compilation support to swift-distributed-tracing #174
Conversation
|
@FranzBusch @ktoso would either of you have a moment to review? |
|
@scottmarchant could you update PR description to refer to official swift.org Swift SDKs for Wasm instead of SwiftWasm? Thanks! |
scottmarchant
changed the title
@MaxDesiatov Done. I updated my other existing PR's as well. |
scottmarchant
force-pushed
the
feat/swift-wasm-support
branch
from
62ca5b1 to
bfdfbad
Compare
|
Note, latest push was just rebasing these changes onto the latest tip of |
| @@ -35,6 +35,7 @@ let package = Package( | |||
| dependencies: [ | |||
| .product(name: "ServiceContextModule", package: "swift-service-context"), | |||
| .target(name: "Instrumentation"), | |||
| .target(name: "_CWASI", condition: .when(platforms: [.wasi])), | |||
There was a problem hiding this comment.
We seem to be getting an error on this line on 5.10
error: Target Tracing imports another target (_CWASI) in the package without declaring it a dependency.
Is this a bug in the package manager on 5.10? Can you take a look and if it is a bug we can just disable the strict dependency check on just 5.10
| #else | ||
| #error("Unsupported runtime") | ||
| #endif | ||
|
|
||
| #if canImport(_CWASI) |
There was a problem hiding this comment.
| #if canImport(_CWASI) | |
| #if os(WASI) |
|
@scottmarchant would you mind addressing formatting job failures per the build log? https://github.com/apple/swift-distributed-tracing/actions/runs/16578688393/job/46920017078?pr=174 |
Summary
This PR adds support for compiling swift-distributed-tracing to wasm using the Swift SDK for WebAssembly.
This PR is part of a larger effort by a company called PassiveLogic to enable broad support for Swift WebAssembly compilation.
Details
There are three changes required to enable wasm compilation for swift-distributed-tracing.
import Dispatchimports. The Swift SDK for WebAssembly doesn't currently include GCD. Luckily, all usage of GCD was unused.Testing done
swift buildcompletes without errorsswift build --swift-sdk wasm32-unknown-wasicompletes without errorsswift build --swift-sdk wasm32-unknown-wasip1-threadscompletes without errorsswift package --swift-sdk wasm32-unknown-wasip1-threads js --use-cdnImpact Risk
Realistically, this change should not cause any impact or risk. Outside of wasm targets, the changes in this PR are additive.