Distributed singleton should be more careful with handover #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-distributed-singleton-ensure-active
branch
from
7af996b to
c60fc7d
Compare
ktoso
commented
Jul 3, 2023
| } | ||
| } catch { | ||
| throw error | ||
| } |
There was a problem hiding this comment.
This do/catch is just here so we can add debug logging, will do shortly
ktoso
commented
Jul 3, 2023
| capInterval: settings.locateActiveSingletonBackoff.capInterval, | ||
| randomFactor: settings.locateActiveSingletonBackoff.randomFactor, | ||
| maxAttempts: settings.locateActiveSingletonBackoff.maxAttempts | ||
| ).attempt { |
There was a problem hiding this comment.
Backoff.exponential().attemtpt {} is very nice, we're finally beginning to reap benefits of async/await inside the cluster :)
|
Minor follow up ticket #1129 |
|
I'll merge so we have less flaky tests but please do review when you're back from break @yim-lee ! |
yim-lee
reviewed
Jul 3, 2023
| var backoff = self | ||
| var lastError: Error? | ||
| defer { | ||
| pprint("RETURNING NOW singleton") |
There was a problem hiding this comment.
Not intended to keep here I think?
| case .none: | ||
| self.updateSingleton(nil) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: would like to return `Act?` but can't via the generic combining with Codable: rdar://111664985 & https://github.com/apple/swift/issues/67090 |
There was a problem hiding this comment.
Solution incoming here: swiftlang/swift#67117
| @@ -267,8 +310,8 @@ internal distributed actor ClusterSingletonBoss<Act: ClusterSingleton>: ClusterS | |||
| try await singletonFactory(self.actorSystem) | |||
| } | |||
|
|
|||
| await singleton.whenLocal { __secretlyKnownToBeLocal in // TODO(distributed): this is annoying, we must track "known to be local" in | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't review yet;
Resolves #1123 by hardedning how the redirecring is done. This is still not optimal but hit IRGen issue