build: distribute CCryptoBoringSSL #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
boring-modules
branch
from
220808c to
5e8fdbf
Compare
The `include` directory is required for the interface include directories for using `CCryptoBoringSSL` as a module from an external package (i.e. SPM). This allows SPM to include `CCryptoBoringSSL` and find the module map.
compnerd
force-pushed
the
boring-modules
branch
from
5e8fdbf to
341993a
Compare
|
Verified locally that this fixes the build for swiftlang/swift-package-manager#3238 Thanks so much @compnerd! |
yim-lee
approved these changes
Feb 6, 2021
|
Merging so we can test with SwiftPM CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we distribute CCryptoBoringSSL for users as it is used
directly by SPM.
[One line description of your change]
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]