Skip to content

build: allow using a build tree of dispatch, Foundation #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

compnerd
Copy link
Contributor

@compnerd compnerd commented Feb 4, 2021

When building swift-crypto from source for a toolchain build, it is
convenient to build it without building up a toolchain image. This
additional knob allows for building swift-crypto with the build
artifacts of previous builds, allowing building up a toolchain image
while chaining multiple builds together.

[One line description of your change]

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

When building swift-crypto from source for a toolchain build, it is
convenient to build it without building up a toolchain image.  This
additional knob allows for building swift-crypto with the build
artifacts of previous builds, allowing building up a toolchain image
while chaining multiple builds together.
@compnerd
Copy link
Contributor Author

compnerd commented Feb 4, 2021

CC: @yim-lee @tomerd @Lukasa

@Lukasa
Copy link
Contributor

Lukasa commented Feb 4, 2021

Waiting for @yim-lee to review as well.

Copy link
Member

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested SwiftPM build locally with these changes on Mac and Linux.

@Lukasa Lukasa merged commit 26d3f52 into apple:main Feb 5, 2021
@compnerd compnerd deleted the build-tree branch February 6, 2021 17:52
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Feb 8, 2021
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Feb 8, 2021
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Feb 9, 2021
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants