Update/Fix CMake build #65
Conversation
Motivation: SwiftPM's CMake build (swiftlang/swift-package-manager#3202) unsuccessful even with apple#60. Modifications: - Use consistent `SWIFT_CRYPTO_EXPORTS` naming. In some places `CRYPTO_EXPORTS` was used instead. - Install `CCryptoBoringSSL` so we can import it in code (see swiftlang/swift-package-manager#3202) - Always set `BUILD_SHARED_LIBS` Result: Successful CMake build.
yim-lee
force-pushed
the
fix-cmake-build
branch
from
a2ae84f to
3f6c2f8
Compare
Requires apple/swift-crypto#65
|
@compnerd ptal |
|
Hmm, does the client need to link against CCryptoBoringSSL or just import it? (that is, it needs the headers and the module map?) Installation of just the library would be insufficient for that. In fact, if the module is needed because it is a dependency for the rest of the code, I think that the better thing might be to use it as |
|
Just to make sure I understand everything - this is just a renaming of the exports file and nothing more? |
|
Not installing |
This is renaming exports file and vars plus always setting |
|
@Lukasa good to merge? |
Requires apple/swift-crypto#65
Requires apple/swift-crypto#65
Motivation: Package collections feature will require swift-crypto dependency. Modifications: - Add swift-crypto dependency - Bump minimum macOS version to 10.15, for it's required by swift-crypto Requires apple/swift-crypto#65
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Motivation:
SwiftPM's CMake build
(swiftlang/swift-package-manager#3202) unsuccessful
even with #60.
Modifications:
SWIFT_CRYPTO_EXPORTSnaming. In some placesCRYPTO_EXPORTSwas used instead.CCryptoBoringSSLso we can import it in code (see Add swift-crypto dependency swiftlang/swift-package-manager#3202)BUILD_SHARED_LIBSResult:
Successful CMake build.