ContainerRegistry: The registry may return a relative blob upload URL #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return value URL's .appending(queryItems:) method can be used to append the digest to the upload location URL; URLComponents is not needed. .appending(queryItems:) always succeeds, so we do not need to check for nil in putBlob() and can instead throw in startBlobUploadSession if necessary.
Motivation ---------- In the 'Post then Put' blob upload method (https://github.com/opencontainers/distribution-spec/blob/main/spec.md#post-then-put) the client starts by making a POST request asking the registry to start an upload session. The registry responds with a URL to which the client should PUT the blob. The upload location might not be provided by the registry server, allowing the registry to offload storage to a different service. Until now all registries we have encountered have returned absolute upload URLs, however GHCR returns a relative URL causing uploads to fail as reported in apple#43. Modifications ------------- If the registry returns a relative URL, startBlobUpload() rewrites it to be an absolute URL referring to the registry. Result ------ Images can be pushed to GHCR and other registries which return relative upload locations. Test Plan --------- Automated tests continue to pass. Tested manually with GHCR and other known registries. Fixes: apple#43
euanh
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the 'Post then Put' blob upload method
(https://github.com/opencontainers/distribution-spec/blob/main/spec.md#post-then-put)
the client starts by making a POST request asking the registry to
start an upload session. The registry responds with a URL to which
the client should PUT the blob. The upload location might not be
provided by the registry server, allowing the registry to offload
storage to a different service.
Until now all registries we have encountered have returned absolute
upload URLs, however GHCR returns a relative URL causing uploads to
fail as reported in #43.
Modifications
If the registry returns a relative URL, startBlobUpload() rewrites it
to be an absolute URL referring to the registry.
Result
Images can be pushed to GHCR and other registries which return relative
upload locations.
Test Plan
Automated tests continue to pass.
Tested manually with GHCR and other known registries.
Fixes: #43