This repository was archived by the owner on Mar 28, 2020. It is now read-only.
[TSan] Ensure libc++ can be built for TSan tests on Linux #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yln
force-pushed
the
PR-test-linux-tsan-libcxx-link-libdispatch
branch
3 times, most recently
from
caeb469 to
0be5677
Compare
yln
changed the title
Required change to make "Swift CI preset for LLVM libdispatch tests" [1] work. This goes the opposite direction of [2, 3], ensuring that the link step succeeds for the produced dynamic library (*.so). In the future versions of compiler-rt this will not be necessary since we will create a static archive instead. [1] swiftlang/swift#24330 [2] https://reviews.llvm.org/D58013 [3] https://reviews.llvm.org/rG0a9cb239a6c91a709a98c96bbf60b6c006d5a07b rdar://problem/50828689
yln
force-pushed
the
PR-test-linux-tsan-libcxx-link-libdispatch
branch
from
0be5677 to
32b08ca
Compare
|
Updated |
|
Landing now. Reviewed by Devin and Kuba. CCC approved by Ted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required change to make "Swift CI preset for LLVM libdispatch tests" [1]
work.
This goes the opposite direction of [2, 3], ensuring that the link step
succeeds for the produced dynamic library (*.so). In the future versions
of compiler-rt this will not be necessary since we will create a static
archive instead.
[1] swiftlang/swift#24330
[2] https://reviews.llvm.org/D58013
[3] https://reviews.llvm.org/rG0a9cb239a6c91a709a98c96bbf60b6c006d5a07b
rdar://problem/50828689