[Import as member] Module attribute swift_infer_import_as_member

include/clang/APINotes/APINotesManager.h

@@ -111,6 +111,10 @@ class APINotesManager {
 
   /// Find the API notes reader that corresponds to the given source location.
   APINotesReader *findAPINotes(SourceLocation Loc);
+
+  APINotesReader *getCurrentModuleReader() {
+    return CurrentModuleReader.get();
+  }
 };
 
 } // end namespace api_notes

include/clang/APINotes/APINotesReader.h

@@ -50,6 +50,9 @@ class APINotesReader {
   /// notes.
   StringRef getModuleName() const;
 
+  /// Retrieve the module options
+  ModuleOptions getModuleOptions() const;
+
   /// Look for information regarding the given Objective-C class.
   ///
   /// \param name The name of the class we're looking for.

include/clang/APINotes/APINotesWriter.h

@@ -107,6 +107,9 @@ class APINotesWriter {
   /// \param name The name of this typedef.
   /// \param info Information about this typedef.
   void addTypedef(StringRef name, const TypedefInfo &info);
+
+  /// Add module options
+  void addModuleOptions(ModuleOptions opts);
 };
 
 } // end namespace api_notes

include/clang/APINotes/Types.h

@@ -474,6 +474,11 @@ class TypedefInfo : public CommonTypeInfo {
   TypedefInfo() : CommonTypeInfo() { }
 };
 
+/// Descripts a series of options for a module
+struct ModuleOptions {
+  bool SwiftInferImportAsMember;
+};
+
 } // end namespace api_notes
 } // end namespace clang
 

include/clang/Basic/Module.h

@@ -183,6 +183,9 @@ class Module {
   /// \brief Whether this is an inferred submodule (module * { ... }).
   unsigned IsInferred : 1;
 
+  /// \brief Whether this is a module who has its swift_names inferred.
+  unsigned IsSwiftInferImportAsMember : 1;
+
   /// \brief Whether we should infer submodules for this module based on 
   /// the headers.
   ///

include/clang/Lex/ModuleMap.h

@@ -176,6 +176,9 @@ class ModuleMap {
 
     /// \brief Whether this is an exhaustive set of configuration macros.
     unsigned IsExhaustive : 1;
+
+    /// \brief Whether this is a module who has its swift_names inferred.
+    unsigned IsSwiftInferImportAsMember : 1;
   };
 
   /// \brief A directory for which framework modules can be inferred.

lib/APINotes/APINotesFormat.h

@@ -35,7 +35,7 @@ const uint16_t VERSION_MAJOR = 0;
 /// API notes file minor version number.
 ///
 /// When the format changes IN ANY WAY, this number should be incremented.
-const uint16_t VERSION_MINOR = 10;  // enum constants
+const uint16_t VERSION_MINOR = 11;  // SwiftInferImportAsMember
 
 using IdentifierID = Fixnum<31>;
 using IdentifierIDField = BCVBR<16>;
@@ -104,7 +104,8 @@ namespace control_block {
   // VERSION_MAJOR.
   enum {
     METADATA = 1,
-    MODULE_NAME = 2
+    MODULE_NAME = 2,
+    MODULE_OPTIONS = 3
   };
 
   using MetadataLayout = BCRecordLayout<
@@ -117,6 +118,11 @@ namespace control_block {
     MODULE_NAME,
     BCBlob       // Module name
   >;
+
+  using ModuleOptionsLayout = BCRecordLayout<
+    MODULE_OPTIONS,
+    BCFixed<1> // SwiftInferImportAsMember
+  >;
 }
 
 namespace identifier_block {

lib/APINotes/APINotesReader.cpp

@@ -562,6 +562,9 @@ class APINotesReader::Implementation {
   /// The name of the module that we read from the control block.
   std::string ModuleName;
 
+  /// Various options and attributes for the module
+  ModuleOptions ModuleOpts;
+
   using SerializedIdentifierTable =
       llvm::OnDiskIterableChainedHashTable<IdentifierTableInfo>;
 
@@ -735,6 +738,10 @@ bool APINotesReader::Implementation::readControlBlock(
       ModuleName = blobData.str();
       break;
 
+    case control_block::MODULE_OPTIONS:
+      ModuleOpts.SwiftInferImportAsMember = (scratch.front() & 1) != 0;
+      break;
+
     default:
       // Unknown metadata record, possibly for use by a future version of the
       // module format.
@@ -1440,6 +1447,10 @@ StringRef APINotesReader::getModuleName() const {
   return Impl.ModuleName;
 }
 
+ModuleOptions APINotesReader::getModuleOptions() const {
+  return Impl.ModuleOpts;
+}
+
 auto APINotesReader::lookupObjCClass(StringRef name)
        -> Optional<std::pair<ContextID, ObjCContextInfo>> {
   if (!Impl.ObjCContextTable)

lib/APINotes/APINotesWriter.cpp

@@ -43,6 +43,8 @@ class APINotesWriter::Implementation {
   /// The name of the module
   std::string ModuleName;
 
+  bool SwiftInferImportAsMember = false;
+
   /// Information about Objective-C contexts (classes or protocols).
   ///
   /// Indexed by the identifier ID and a bit indication whether we're looking
@@ -214,6 +216,11 @@ void APINotesWriter::Implementation::writeControlBlock(
 
   control_block::ModuleNameLayout moduleName(writer);
   moduleName.emit(ScratchRecord, ModuleName);
+
+  if (SwiftInferImportAsMember) {
+    control_block::ModuleOptionsLayout moduleOptions(writer);
+    moduleOptions.emit(ScratchRecord, SwiftInferImportAsMember);
+  }
 }
 
 namespace {
@@ -1091,3 +1098,8 @@ void APINotesWriter::addTypedef(llvm::StringRef name, const TypedefInfo &info) {
   assert(!Impl.Typedefs.count(typedefID));
   Impl.Typedefs[typedefID] = info;
 }
+
+void APINotesWriter::addModuleOptions(ModuleOptions opts) {
+  Impl.SwiftInferImportAsMember = opts.SwiftInferImportAsMember;
+}
+

lib/APINotes/APINotesYAMLCompiler.cpp

@@ -250,6 +250,8 @@ namespace {
     TagsSeq Tags;
     TypedefsSeq Typedefs;
 
+    llvm::Optional<bool> SwiftInferImportAsMember;
+
     LLVM_ATTRIBUTE_DEPRECATED(
       void dump() LLVM_ATTRIBUTE_USED,
       "only for use within the debugger");
@@ -416,6 +418,7 @@ namespace llvm {
         io.mapRequired("Name",            m.Name);
         io.mapOptional("Availability",    m.Availability.Mode);
         io.mapOptional("AvailabilityMsg", m.Availability.Msg);
+        io.mapOptional("SwiftInferImportAsMember", m.SwiftInferImportAsMember);
         io.mapOptional("Classes",         m.Classes);
         io.mapOptional("Protocols",       m.Protocols);
         io.mapOptional("Functions",       m.Functions);
@@ -771,6 +774,9 @@ namespace {
         Writer->addTypedef(t.Name, typedefInfo);
       }
 
+      if (TheModule.SwiftInferImportAsMember) 
+        Writer->addModuleOptions({true});
+
       if (!ErrorOccured)
         Writer->writeToStream(OS);
 
@@ -1032,6 +1038,11 @@ bool api_notes::decompileAPINotes(std::unique_ptr<llvm::MemoryBuffer> input,
   // Set module name.
   module.Name = reader->getModuleName();
 
+  // Set module options
+  auto opts = reader->getModuleOptions();
+  if (opts.SwiftInferImportAsMember)
+    module.SwiftInferImportAsMember = true;
+
   // Sort classes.
   std::sort(module.Classes.begin(), module.Classes.end(),
             [](const Class &lhs, const Class &rhs) -> bool {

lib/Basic/Module.cpp

@@ -337,6 +337,8 @@ void Module::print(raw_ostream &OS, unsigned Indent) const {
       OS << " [system]";
     if (IsExternC)
       OS << " [extern_c]";
+    if (IsSwiftInferImportAsMember)
+      OS << " [swift_infer_import_as_member]";
   }
 
   OS << " {\n";

lib/Frontend/CompilerInstance.cpp

@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "clang/Frontend/CompilerInstance.h"
+#include "clang/APINotes/APINotesReader.h"
 #include "clang/AST/ASTConsumer.h"
 #include "clang/AST/ASTContext.h"
 #include "clang/AST/Decl.h"
@@ -533,10 +534,21 @@ void CompilerInstance::createSema(TranslationUnitKind TUKind,
                          TUKind, CompletionConsumer));
 
   // If we're building a module, notify the API notes manager.
-  if (!getLangOpts().CurrentModule.empty()) {
+  StringRef currentModuleName = getLangOpts().CurrentModule;
+  if (!currentModuleName.empty()) {
     (void)TheSema->APINotes.loadCurrentModuleAPINotes(
-            getLangOpts().CurrentModule,
+            currentModuleName,
             getAPINotesOpts().ModuleSearchPaths);
+    // Check for any attributes we should add to the module
+    if (auto curReader = TheSema->APINotes.getCurrentModuleReader()) {
+      auto currentModule = getPreprocessor().getCurrentModule();
+      assert(currentModule && "how can we have a reader for it?");
+
+      // swift_infer_import_as_member
+      if (curReader->getModuleOptions().SwiftInferImportAsMember) {
+        currentModule->IsSwiftInferImportAsMember = true;
+      }
+    }
   }
 }
 

lib/Lex/ModuleMap.cpp

@@ -1306,7 +1306,9 @@ namespace {
     /// \brief The 'extern_c' attribute.
     AT_extern_c,
     /// \brief The 'exhaustive' attribute.
-    AT_exhaustive
+    AT_exhaustive,
+    // \brief The 'swift_infer_import_as_member' attribute.
+    AT_swift_infer_import_as_member,
   };
 }
 
@@ -2379,6 +2381,7 @@ bool ModuleMapParser::parseOptionalAttributes(Attributes &Attrs) {
           .Case("exhaustive", AT_exhaustive)
           .Case("extern_c", AT_extern_c)
           .Case("system", AT_system)
+          .Case("swift_infer_import_as_member", AT_swift_infer_import_as_member)
           .Default(AT_unknown);
     switch (Attribute) {
     case AT_unknown:
@@ -2394,6 +2397,10 @@ bool ModuleMapParser::parseOptionalAttributes(Attributes &Attrs) {
       Attrs.IsExternC = true;
       break;
 
+    case AT_swift_infer_import_as_member:
+      Attrs.IsSwiftInferImportAsMember = true;
+      break;
+
     case AT_exhaustive:
       Attrs.IsExhaustive = true;
       break;

test/APINotes/Inputs/Headers/APINotes.apinotes

@@ -1,4 +1,5 @@
 Name: HeaderLib
+SwiftInferImportAsMember: true
 Functions:
   - Name: custom_realloc
     NullabilityOfRet: N

test/APINotes/Inputs/roundtrip.apinotes

@@ -2,6 +2,7 @@
 Name:            AppKit
 Availability:    available
 AvailabilityMsg: ''
+SwiftInferImportAsMember: true
 Classes:         
   - Name:            NSCell
     Availability:    available

test/Modules/Inputs/swift_name/module.modulemap

@@ -0,0 +1,2 @@
+module SwiftNameInferred [swift_infer_import_as_member] {
+}

test/Modules/infer_swift_name.m

@@ -0,0 +1,6 @@
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs/swift_name %s -verify
+// REQUIRES: shell
+
+@import SwiftNameInferred; // ok
+@import SwiftName; // expected-error{{module 'SwiftName' not found}}