Skip to content

Feature: Enhance RDN parsing to support IA5String #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 10, 2025
Merged

Feature: Enhance RDN parsing to support IA5String #236

merged 11 commits into from
Apr 10, 2025

Conversation

erikgadireddi
Copy link
Contributor

@erikgadireddi erikgadireddi commented Mar 25, 2025 •
edited
Loading

Add capability of converting RDN value of ASN1IA5String to String, if I am correct all RFC expect that RDN value can be ASN1IA5String..

  • additionally fix tests after this change
  • added DN components emailAddress(E) and domainComponent(DC)

@erikgadireddi
feat(RDN-ASN1IA5String)
0634f90 
Add capability of converting RDN  value of ASN1IA5String can be converted to String
- additionally fix tests after this change
@erikgadireddi erikgadireddi mentioned this pull request Mar 25, 2025
Closed
@erikgadireddi
feat(dc,e):
dac1f38 
- add asn1identifiers for emailAdress and domainComponent
- add new DSL types DomainComponent and EmailAdress
@erikgadireddi
maintanance(update comment)
b731141
dnadoba
dnadoba approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like a very nice addition. I will defer to Cory to do the final review. Note that it might take some time until he can have a look.

@erikgadireddi erikgadireddi requested a review from dnadoba March 27, 2025 17:36
Lukasa
Lukasa reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor nits, but otherwise this looks really good.

@erikgadireddi erikgadireddi requested a review from Lukasa April 9, 2025 14:56
@erikgadireddi
Copy link
Contributor Author

I fixed the comments, good catch ! @Lukasa
Thanks for keeping the highest standard.

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Apr 9, 2025
Lukasa
Lukasa approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shiny, this looks good. Let's see what CI says.

@Lukasa
Copy link
Contributor

Lukasa commented Apr 9, 2025

Looks like a few formatting tweaks need to be made.

@erikgadireddi
Copy link
Contributor Author

I hope I fixed, the formatting.. I was not aware of swift-format tool in xcode 16.
Please re-run the workflows, I think I do not have enough permissions to do it myself..

@erikgadireddi erikgadireddi requested a review from Lukasa April 10, 2025 11:21
@Lukasa Lukasa enabled auto-merge (squash) April 10, 2025 13:57
@Lukasa Lukasa merged commit bdcbccd into apple:main Apr 10, 2025
35 checks passed
@Lukasa
Copy link
Contributor

Lukasa commented Apr 10, 2025

Thanks so much @erikgadireddi!

@erikgadireddi erikgadireddi deleted the feat/add_ia5String_to_RDN branch April 12, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadoba dnadoba Awaiting requested review from dnadoba

@Lukasa Lukasa Awaiting requested review from Lukasa

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikgadireddi @Lukasa @dnadoba