Stop implicitly tagging DistinguishedName #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DistinguishedName was incorrectly marked DERImplicitlyTaggable, but it isn't. DistinguishedName is our name for Name, which is an untagged choice type. Untagged choice types can never be implicitly tagged.
FranzBusch
approved these changes
Aug 15, 2024
dnadoba
approved these changes
Aug 15, 2024
| } | ||
| } | ||
|
|
||
| @available(*, deprecated, message: "Distinguished names may not be implicitly tagged") |
There was a problem hiding this comment.
Is this enough or do we also need to deprecate each symbol declared in the extension?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DistinguishedName was incorrectly marked DERImplicitlyTaggable, but it isn't. DistinguishedName is our name for Name, which is an untagged choice type. Untagged choice types can never be implicitly tagged.
Resolves #177