Avoid C atomic operations in Swift 5.9+ #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpiled as C++ `_Atomic(_sa_dword)` trips up C++. This is likely due to real issues, but it seems pointless to try to fix it — rather than heroically trying to keep this header working, we can simply force the use of native builtins on Swift 5.9 and later. (I planned to do that anyway, as a major step towards deleting `_AtomicsShims` altogether.)
Switch from the classic `-parse-stdlib` option to the new `BuiltinModule` experimental feature.
|
@swift-ci test |
|
@swift-ci test |
|
This pull breaks building the latest trunk of this package with Swift 5.8, as can be seen on my daily Android CI, and presumably 5.7 too. Maybe this can be reconfigured in such a way that |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
_AtomicsShimswith C++ interoperability enabled uncovers some issues with double-wide atomics as currently implemented in C.It's time to stop tweaking these C definitions -- instead, disable C atomics, and switch to using native Swift atomic operations from Swift 5.9 onward.
(For now, we'll still need
_AtomicsShimsfor itsswift_retain_n/swift_release_nwrappers. I'm planning to get rid of the need for those, too, but that'll need some compiler tweaks that aren't targeted for 5.9.)Resolves #88.
Checklist