Fix Linux compatibility #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an “unable to typecheck in reasonable time” error when compiling the test registry. 1612 tests under one test case is currently too many for swift-corelibs-xctest. While we’re here, add explicit test cases for UnsafeRawPointer and Optional<UnsafeRawPointer>.
Linux on x86_64 unfortunately disables support for cmpxchg16 by default, making double-wide atomic operations fall back to using locks. We cannot currently override this on the package level, so stop providing double-wide atomics in this configuration by default. To enable codegen support for double-wide atomics on Linux/x86_64, compile the package with `-Xcc -mcx16 -Xswiftc -DENABLE_DOUBLEWIDE_ATOMICS`.
SPM’s --generate-linuxmain feature doesn’t support conditionally compiled tests. To run tests on non-Darwin platforms, use `swift test --enable-test-discovery`.
lorentey
force-pushed
the
restore-linux-support
branch
from
963e3a7 to
ed324ec
Compare
lorentey
force-pushed
the
restore-linux-support
branch
from
82bfd8d to
230c1aa
Compare
This package requires --enable-test-discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues preventing this package from working as designed on Linux:
-Xcc -mcx16.Closes #10.