Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SWIFTCI_USE_LOCAL_DEPS convention #311

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add support for SWIFTCI_USE_LOCAL_DEPS convention #311

merged 1 commit into from
Apr 10, 2024

Conversation

kateinoigakukun
Copy link
Contributor

This package is used by https://github.com/apple/swift-sdk-generator and it needs to be built during build-script pipeline, so we need to make its dependencies follow the CI convention. CC: @MaxDesiatov

@kateinoigakukun
Add support for SWIFTCI_USE_LOCAL_DEPS convention
a900d2b 
To use this package in utils/build-script pipeline
@kateinoigakukun
Copy link
Contributor Author

@swift-ci test

MaxDesiatov
MaxDesiatov approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phausler phausler merged commit 6ae9a05 into apple:main Apr 10, 2024
2 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/use-local-deps branch April 11, 2024 01:24
@kateinoigakukun
Copy link
Contributor Author

@phausler Would you mind having a new tag to pin the version including this fix in update-checkout-config.json if possible? 🙏

@kkebo
Copy link

kkebo commented Jun 17, 2024 •
edited
Loading

This PR has broken apps depending on swift-async-algorithms on Swift Playgrounds on iPadOS.

  • iPadOS 18 Developer Beta 1
  • Swift Playgrounds 4.5.1

IMG_0442

The reproducible example is here. Or, you can reproduce the issue by the following steps.

  1. Create a new app on Swift Playgrounds (iPadOS)
  2. Add a swift package
  3. Input https://github.com/apple/swift-async-algorithms to the "Package URL" field
  4. Press the return key

Then, the following error will be shown.

error message 
Could not resolve package graph. Cannot continue.

unknownError(PlaygroundExecution.ConsoleReadingExecutionOperation.OperationError.failed(PlaygroundExecution.ExecutionError.remoteProcessWasInterrupted, Optional(["ThreadInfoDictionaries": <__NSFrozenArrayM 0x307900540>(
{
    DispatchQueueName = "com.apple.main-thread";
    StackFrameDictionaries =     (
                {
            CrashAnnotationMessage = "PackageDescription/Context.swift:19: Fatal error: 'try!' expression unexpectedly raised an error: Could not decode ContextModel parameter.\n";
            StackFrameModule = "libswiftCore.dylib";
            StackFramePC = 6842454440;
            StackFrameSymbolName = "_$ss17_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_SSAHSus6UInt32VtF";
        },
                {
            CrashAnnotationMessage = "PackageDescription/Context.swift:19: Fatal error: 'try!' expression unexpectedly raised an error: Could not decode ContextModel parameter.\n";
            StackFrameModule = "libswiftCore.dylib";
            StackFramePC = 6842925296;
            StackFrameSymbolName = "_swift_unexpectedError";
        },
                {
            StackFrameModule = "libPackageDescription.dylib";
            StackFramePC = 4465283188;
            StackFrameSymbolName = "_$s18PackageDescription7ContextV5model33_16EFAD36DA072BCD1C8EFF86E7A18833LL_WZ";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002132832;
            StackFrameSymbolName = "__dispatch_client_callout";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002139048;
            StackFrameSymbolName = "__dispatch_once_callout";
        },
                {
            StackFrameModule = "libPackageDescription.dylib";
            StackFramePC = 4465283448;
            StackFrameSymbolName = "_$s18PackageDescription7ContextV11environmentSDyS2SGvgZ";
        },
                {
            StackFrameModule = "manifest_bjwdoqlmuklnzyeenvxrrponpzzy";
            StackFramePC = 4377719596;
            StackFrameSymbolName = "_main";
        },
                {
            StackFrameModule = ExecutionExtension;
            StackFramePC = 4374972024;
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869403044;
            StackFrameSymbolName = "___CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869330004;
            StackFrameSymbolName = "___CFRunLoopDoBlocks";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869327644;
            StackFrameSymbolName = "___CFRunLoopRun";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869325588;
            StackFrameSymbolName = "_CFRunLoopRunSpecific";
        },
                {
            StackFrameModule = GraphicsServices;
            StackFramePC = 8138953156;
            StackFrameSymbolName = "_GSEventRunModal";
        },
                {
            StackFrameModule = UIKitCore;
            StackFramePC = 6914872676;
            StackFrameSymbolName = "-[UIApplication _run]";
        },
                {
            StackFrameModule = UIKitCore;
            StackFramePC = 6915585328;
            StackFrameSymbolName = "_UIApplicationMain";
        },
                {
            StackFrameModule = "libxpc.dylib";
            StackFramePC = 9129525396;
            StackFrameSymbolName = "__xpc_objc_uimain";
        },
                {
            StackFrameModule = "libxpc.dylib";
            StackFramePC = 9129524880;
            StackFrameSymbolName = "__xpc_objc_main";
        },
                {
            StackFrameModule = "libxpc.dylib";
            StackFramePC = 9129534688;
            StackFrameSymbolName = "__xpc_main";
        },
                {
            StackFrameModule = "libxpc.dylib";
            StackFramePC = 9129535168;
            StackFrameSymbolName = "_xpc_main";
        },
                {
            StackFrameModule = Foundation;
            StackFramePC = 6849683752;
            StackFrameSymbolName = "-[NSXPCListener resume]";
        },
                {
            StackFrameModule = PlugInKit;
            StackFramePC = 7673820444;
        },
                {
            StackFrameModule = PlugInKit;
            StackFramePC = 7673820072;
        },
                {
            StackFrameModule = PlugInKit;
            StackFramePC = 7673819236;
        },
                {
            StackFrameModule = PlugInKit;
            StackFramePC = 7673821304;
        },
                {
            StackFrameModule = ExtensionFoundation;
            StackFramePC = 7123324860;
            StackFrameSymbolName = "_EXExtensionMain";
        },
                {
            StackFrameModule = Foundation;
            StackFramePC = 6850132160;
            StackFrameSymbolName = "_NSExtensionMain";
        },
                {
            StackFrameModule = dyld;
            StackFramePC = 7502216400;
            StackFrameSymbolName = start;
        }
    );
    ThreadCrashed = 1;
    ThreadID = 461139;
    ThreadIsMain = 1;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461141;
},
{
    DispatchQueueName = "com.apple.root.user-initiated-qos";
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470748;
            StackFrameSymbolName = "___ulock_wait2";
        },
                {
            StackFrameModule = "libsystem_platform.dylib";
            StackFramePC = 9128407640;
            StackFrameSymbolName = "__os_unfair_lock_lock_slow";
        },
                {
            StackFrameModule = "libobjc.A.dylib";
            StackFramePC = 6822743572;
            StackFrameSymbolName = "_objc_sync_enter";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952426860;
            StackFrameSymbolName = "-[PKInkManager inkBehaviorForIdentifier:version:variant:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952430448;
            StackFrameSymbolName = "-[PKInk initWithUncheckedIdentifier:color:version:variant:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952430788;
            StackFrameSymbolName = "-[PKInk initWithIdentifier:color:version:variant:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7955115692;
            StackFrameSymbolName = "+[PKInk inkWithIdentifier:color:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953821656;
            StackFrameSymbolName = "+[PKTextInputCanvasController defaultInkWithColor:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953821452;
            StackFrameSymbolName = "+[PKTextInputCanvasController prewarmFutureCanvasesIfNecessarySecureRendering:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953196616;
            StackFrameSymbolName = "___40-[PKTextInputInteraction didMoveToView:]_block_invoke.32";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002125312;
            StackFrameSymbolName = "__dispatch_call_block_and_release";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002132832;
            StackFrameSymbolName = "__dispatch_client_callout";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002206152;
            StackFrameSymbolName = "__dispatch_root_queue_drain";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002207736;
            StackFrameSymbolName = "__dispatch_worker_thread2";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129122880;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461142;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461143;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461144;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461145;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209471240;
            StackFrameSymbolName = "_mach_msg2_trap";
        },
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209485336;
            StackFrameSymbolName = "_mach_msg2_internal";
        },
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209485104;
            StackFrameSymbolName = "_mach_msg_overwrite";
        },
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209484668;
            StackFrameSymbolName = "_mach_msg";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869330372;
            StackFrameSymbolName = "___CFRunLoopServiceMachPort";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869327992;
            StackFrameSymbolName = "___CFRunLoopRun";
        },
                {
            StackFrameModule = CoreFoundation;
            StackFramePC = 6869325588;
            StackFrameSymbolName = "_CFRunLoopRunSpecific";
        },
                {
            StackFrameModule = Foundation;
            StackFramePC = 6849024176;
            StackFrameSymbolName = "-[NSRunLoop(NSRunLoop) runMode:beforeDate:]";
        },
                {
            StackFrameModule = Foundation;
            StackFramePC = 6849023744;
            StackFrameSymbolName = "-[NSRunLoop(NSRunLoop) runUntilDate:]";
        },
                {
            StackFrameModule = UIKitCore;
            StackFramePC = 6914951340;
            StackFrameSymbolName = "-[UIEventFetcher threadMain]";
        },
                {
            StackFrameModule = Foundation;
            StackFramePC = 6849094124;
            StackFrameSymbolName = "___NSThread__start__";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129128828;
            StackFrameSymbolName = "__pthread_start";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108628;
            StackFrameSymbolName = "_thread_start";
        }
    );
    ThreadID = 461146;
    ThreadName = "com.apple.uikit.eventfetch-thread";
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461147;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461148;
},
{
    DispatchQueueName = "com.apple.root.user-initiated-qos";
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libobjc.A.dylib";
            StackFramePC = 6822702140;
            StackFrameSymbolName = "__ZL25getMethodFromRelativeListP20relative_list_list_tI13method_list_tEP13objc_selector";
        },
                {
            StackFrameModule = "libobjc.A.dylib";
            StackFramePC = 6822694876;
            StackFrameSymbolName = "_lookUpImpOrForward";
        },
                {
            StackFrameModule = "libobjc.A.dylib";
            StackFramePC = 6822687972;
            StackFrameSymbolName = "__objc_msgSend_uncached";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952437852;
            StackFrameSymbolName = "+[PKInkParser inkRenderingDescriptorWithDictionary:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952440336;
            StackFrameSymbolName = "+[PKInkParser inkBehaviorsWithIdentifer:version:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952426964;
            StackFrameSymbolName = "-[PKInkManager inkBehaviorForIdentifier:version:variant:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952430448;
            StackFrameSymbolName = "-[PKInk initWithUncheckedIdentifier:color:version:variant:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7952430788;
            StackFrameSymbolName = "-[PKInk initWithIdentifier:color:version:variant:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7955115692;
            StackFrameSymbolName = "+[PKInk inkWithIdentifier:color:weight:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953821656;
            StackFrameSymbolName = "+[PKTextInputCanvasController defaultInkWithColor:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953821452;
            StackFrameSymbolName = "+[PKTextInputCanvasController prewarmFutureCanvasesIfNecessarySecureRendering:]";
        },
                {
            StackFrameModule = PencilKit;
            StackFramePC = 7953196616;
            StackFrameSymbolName = "___40-[PKTextInputInteraction didMoveToView:]_block_invoke.32";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002125312;
            StackFrameSymbolName = "__dispatch_call_block_and_release";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002132832;
            StackFrameSymbolName = "__dispatch_client_callout";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002206152;
            StackFrameSymbolName = "__dispatch_root_queue_drain";
        },
                {
            StackFrameModule = "libdispatch.dylib";
            StackFramePC = 7002207736;
            StackFrameSymbolName = "__dispatch_worker_thread2";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129122880;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461149;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461150;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461151;
},
{
    StackFrameDictionaries =     (
                {
            StackFrameModule = "libsystem_kernel.dylib";
            StackFramePC = 8209470608;
            StackFrameSymbolName = "___workq_kernreturn";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129123016;
            StackFrameSymbolName = "__pthread_wqthread";
        },
                {
            StackFrameModule = "libsystem_pthread.dylib";
            StackFramePC = 9129108616;
            StackFrameSymbolName = "_start_wqthread";
        }
    );
    ThreadID = 461152;
},
{
    StackFrameDictionaries =     (
    );
    ThreadID = 461153;
}
)
, "ExceptionType": 6, "ExceptionData": <01000000 00000000 a891d797 01000000>, "CrashCatcherPID": 1333, "SignalNumber": 5]))) in https://github.com/apple/swift-async-algorithms

@kkebo
Copy link

kkebo commented Jun 17, 2024

It seems that Context is not safe on Swift Playgrounds.

@kkebo kkebo mentioned this pull request Jun 17, 2024
Closed
kkebo added a commit to kkebo/swift-async-algorithms that referenced this pull request Oct 14, 2024
@kkebo
Fix build failure on Swift Playgrounds
51c328e 
\apple#311 introduced `Context.environment`, so that swift-async-algorithm
can no longer be used in the Swift Playgrounds.
However, `Context.environment` is equivalent to
`ProcessInfo.processInfo.environment`, so this is an unnecessary
sacrifice. This change is intended to fix that.
kkebo added a commit to kkebo/swift-async-algorithms that referenced this pull request Oct 14, 2024
@kkebo
Fix build failure on Swift Playgrounds
ad84e42 
The PR apple#311 introduced `Context.environment`, so that swift-async-algorithm
can no longer be used in the Swift Playgrounds.
However, `Context.environment` is equivalent to
`ProcessInfo.processInfo.environment`, so this is an unnecessary
sacrifice. This change is intended to fix that.
@kkebo kkebo mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kateinoigakukun @kkebo @MaxDesiatov @phausler