Add async rethrowing initializers for RangeReplaceableCollection, SetAlgebra, and Dictionary for use with AsyncSequence types #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Algebra, and Dictionary for use with AsyncSequence types
…collection initializers
phausler
changed the title
phausler
requested review from
jmschonfeld,
kperryua,
natecook1000,
parkera and
timvermeulen
natecook1000
approved these changes
Jan 12, 2022
| /// - Parameter surce: The asynchronous sequence of elements for the new collection. | ||
| @inlinable | ||
| public init<Source: AsyncSequence>(_ source: Source) async rethrows where Source.Element == Element { | ||
| self.init() |
There was a problem hiding this comment.
AsyncSequence doesn't have any notion of underestimatedCount, does it?
There was a problem hiding this comment.
nope; AsyncSequence is about 50/50 finite/indefinite so that was decided to be skipped during the initial design.
Co-authored-by: Nate Cook <natecook@apple.com>
Co-authored-by: Nate Cook <natecook@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds asynchronous parity for initialization with collection types for use with AsyncSequence as it exists today for Sequence.