Skip to content

Add abillity to generate hidden help #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Add abillity to generate hidden help #410

merged 1 commit into from
Feb 13, 2022

Conversation

rauhul
Copy link
Contributor

@rauhul rauhul commented Feb 12, 2022

  • Updates helpMessage(columns:) and helpMessage(for:columns:) with an
    includeHidden argument defaulted to false to allow for clients to
    programmatically generate hidden help.

@rauhul rauhul requested a review from natecook1000 February 12, 2022 05:35
@rauhul
Copy link
Contributor Author

rauhul commented Feb 12, 2022

@swift-ci please test

@@ -592,7 +592,7 @@ extension HelpGenerationTests {

func testHelpWithPrivate() {
// For now, hidden and private have the same behaviour
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment isn't accurate anymore - does this test still make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the comment and/or tests in ~an hour!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still adds coverage but I think I'll replace these visibility tests in a future PR.

- Updates helpMessage(columns:) and helpMessage(for:columns:) with an
  includeHidden argument defaulted to false to allow for clients to
  programmatically generate hidden help.
@rauhul
Copy link
Contributor Author

rauhul commented Feb 12, 2022

@swift-ci please test

@natecook1000
Copy link
Member

@swift-ci Please test

@rauhul rauhul merged commit e367368 into apple:main Feb 13, 2022
@rauhul rauhul deleted the public-help-hidden-methods branch February 13, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants