Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that Foundation has to be imported #246

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

johannes-codes
Copy link
Contributor

It's not from the get-go clear for beginners that Foundation has to be imported as well. Otherwise, you would end up with a bunch of compilation errors.

Checklist

  • [-] I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

It's not from the get-go clear for beginners that Foundation has to be imported as well. Otherwise, you would end up with a bunch of compilation errors.
@natecook1000
Copy link
Member

Good call, thanks @pegasuze!

@natecook1000
Copy link
Member

@swift-ci Please smoke test

@natecook1000
Copy link
Member

@swift-ci Please test

1 similar comment
@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit d424bca into apple:main Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants