loadbalancer-experimental: Rename ConnectionPool* types to ConnectionSelector* #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Selector* Motivation: A ConnectionPoolPolicy doesn't actually control pooling, but selection from that pool. The name is also inconsistent with the thing it generates: a ConnectionSelector. Modifications: Rename the types to ConnectionSelector* for more consistincy.
bryce-anderson
force-pushed
the
bl_anderson/ConnectionSelectorStrategy
branch
from
ab94661 to
bf2970f
Compare
bryce-anderson
commented
Dec 18, 2024
Comment on lines
+34
to
36
| * This {@link ConnectionSelectorPolicy} attempts to emulate the pooling behavior often seen in thread pools. | ||
| * Specifically it allows for the configuration of a "core pool" size which are intended to be long-lived. | ||
| * Iteration starts in the core pool at a random position and then iterates through the entire core pool before |
There was a problem hiding this comment.
Note that there are a bunch of usages of the term 'pool' in the documentation here. I think they make sense as many of them are used in analogy to a java thread pools notion of a 'core pool', but there is room for debate.
bryce-anderson
changed the title
|
See #3138 (comment) for the discussion that motivates this PR. |
idelpivnitskiy
approved these changes
Dec 19, 2024
...ancer-experimental/src/main/java/io/servicetalk/loadbalancer/DefaultLoadBalancerBuilder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A ConnectionPoolPolicy doesn't actually control pooling, but selection from that pool. The name is also inconsistent with the thing it generates: a ConnectionSelector.
Modifications:
Rename the types to ConnectionSelector* for more consistincy.