Update Netty 4.1.114 -> 4.1.115 #3097
Merged
+896
−894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
force-pushed
the
netty115
branch
from
00b2c08 to
4d0493a
Compare
idelpivnitskiy
commented
Nov 13, 2024
| @@ -390,6 +390,8 @@ void serverCloseTwoPipelinedRequestsSentBeforeFirstResponse(boolean useUds, bool | |||
| @MethodSource("io.servicetalk.http.netty.ConnectionCloseHeaderHandlingTest#pipelinedRequestsTestData") | |||
| void serverCloseSecondPipelinedRequestWriteAborted(boolean useUds, boolean viaProxy, | |||
| boolean awaitRequestPayload) throws Exception { | |||
| assumeFalse(viaProxy, "Let all other tests run with Netty 4.1.115"); | |||
There was a problem hiding this comment.
Heads up that I had to disable this test to proceed and let benchmarks run with newer Netty
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Nov 13, 2024
This reverts commit 9bf91c4.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Nov 13, 2024
This reverts commit 9bf91c4.
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 14, 2024
…3102) Motivation: Behavior of `SslHandler` in Netty 4.1.115 changed. Now it can wrap data and flush them to the network even if flush was not requested. In result, it affected our test `ConnectionCloseHeaderHandlingTest.PipelinedRequestsTest.serverCloseSecondPipelinedRequestWriteAborted` that we had to disable in #3097 to proceed with the upgrade. Debugging showed that when we receive `AbortWritesEvent`, the following behavior of `WriteStreamSubscriber` depends on how many `activeWrites` we have. With 4.1.115 netty will flush data, there will be 0 `activeWrites` and it will close (with reset) the outbound. In result, we lose data of the previous response in the pipeline that we haven't read yet. Modifications: - Use `listenerDiscard` instead of `channelClosed` that will make sure new writes will be discarded without prematurely affecting the connection state regardless of the `activeWrites` count. - Unskip the test. Result: Graceful handling of `connection: close` header does not depend on flushing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.