Subscribable sources: try-catch onSubscribe and cleanup state if any
#3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: All original sources that implement `handleSubscribe` method should protect from a buggy `Subscriber` that may unexpectedly throw from `onSubscribe`. If they have any state or resource, it should be cleaned up. Modifications: - Find all `Publisher`/`Single`/`Completable` that implement `handleSubscribe` and use `handleExceptionFromOnSubscribe` utility; The following sources clean up their state on exception: - `FromInputStreamPublisher` closes `InputStream`; - `SpliceFlatStreamToMetaSingle` cancels upstream `Subscription`; - `TcpConnector` signals `ConnectionObserver.connectionClosed(t)`; - `TcpServerBinder` cancels bind `Future`; - `NettyChannelPublisher` registers `fatalError` and closes `Channel`; - `DefaultNettyConnection`, `ChannelInitSingle`, `H2ClientParentConnectionContext`, `H2ServerParentConnectionContext` close `Channel`; Results: 1. Best effort to propagate exception via reactive flow. 2. Cleaning up resources.
bryce-anderson
approved these changes
Aug 20, 2024
...talk-tcp-netty-internal/src/main/java/io/servicetalk/tcp/netty/internal/TcpServerBinder.java
Show resolved
Hide resolved
bryce-anderson
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
All original sources that implement
handleSubscribemethod should protect from a buggySubscriberthat may unexpectedly throw fromonSubscribe. If they have any state or resource, it should be cleaned up.Modifications:
Publisher/Single/Completablethat implementhandleSubscribeand usehandleExceptionFromOnSubscribeutility;The following sources clean up their state on exception:
FromInputStreamPublisherclosesInputStream;SpliceFlatStreamToMetaSinglecancels upstreamSubscription;TcpConnectorsignalsConnectionObserver.connectionClosed(t);TcpServerBindercancels bindFutureand closesChannelif necessary;NettyChannelPublisherregistersfatalErrorand closesChannel;DefaultNettyConnection,ChannelInitSingle,H2ClientParentConnectionContext,H2ServerParentConnectionContextcloseChannel;Results: