Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode/Decode grpc-message status per spec #3023

Merged
merged 9 commits into from
Aug 2, 2024
Merged

Commits on Jul 30, 2024

  1. Encode/Decode grpc-message status per spec

    Motivation
    ----------
    At the moment a grpc status message is not percent-encoded which
    the spec mandates. This is not a problem as long as regular printable
    ascii characters are used, but other ranges mandate a percent encoding
    on the wire.
    
    Modifications
    -------------
    This changeset implements the percent encoding/decoding for the
    grpc status message and transparently applies it in the places
    where the ServiceTalk codebase would access the header previously.
    
    The implementation is strongly aligned on the io.grpc equivalent
    in order to ensure maximum compatibility across systems.
    
    Result
    ------
    Properly percent-encoded/decoded grpc-message payload when non
    ascii-printable characters are sent.
    daschl committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    716e351 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    d86c1bd View commit details
    Browse the repository at this point in the history
  2. Fix checkstyle

    daschl committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    707ede1 View commit details
    Browse the repository at this point in the history
  3. pmd fix

    daschl committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    bfe731e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. More polish and tests

    daschl committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c5ee854 View commit details
    Browse the repository at this point in the history
  2. Fix spotbugs complaint

    daschl committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9afe0d4 View commit details
    Browse the repository at this point in the history
  3. Remove unused import

    daschl committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    53c7a46 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Final polish

    daschl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c9fedd5 View commit details
    Browse the repository at this point in the history
  2. Fix checkstyle

    daschl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    77a8083 View commit details
    Browse the repository at this point in the history