-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode/Decode grpc-message status per spec #3023
Merged
Merged
Commits on Jul 30, 2024
-
Encode/Decode grpc-message status per spec
Motivation ---------- At the moment a grpc status message is not percent-encoded which the spec mandates. This is not a problem as long as regular printable ascii characters are used, but other ranges mandate a percent encoding on the wire. Modifications ------------- This changeset implements the percent encoding/decoding for the grpc status message and transparently applies it in the places where the ServiceTalk codebase would access the header previously. The implementation is strongly aligned on the io.grpc equivalent in order to ensure maximum compatibility across systems. Result ------ Properly percent-encoded/decoded grpc-message payload when non ascii-printable characters are sent.
Configuration menu - View commit details
-
Copy full SHA for 716e351 - Browse repository at this point
Copy the full SHA 716e351View commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d86c1bd - Browse repository at this point
Copy the full SHA d86c1bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 707ede1 - Browse repository at this point
Copy the full SHA 707ede1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfe731e - Browse repository at this point
Copy the full SHA bfe731eView commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c5ee854 - Browse repository at this point
Copy the full SHA c5ee854View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9afe0d4 - Browse repository at this point
Copy the full SHA 9afe0d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c7a46 - Browse repository at this point
Copy the full SHA 53c7a46View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9fedd5 - Browse repository at this point
Copy the full SHA c9fedd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a8083 - Browse repository at this point
Copy the full SHA 77a8083View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.