Multi-address client: take advantage of lowercase scheme #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In apple#2938 we made it guaranteed that `HttpRequestMetaData#scheme()` result is always in lowercase. We can use that to simplify scheme checks inside `DefaultMultiAddressUrlHttpClientBuilder`. Modifications: - Replace all scheme checks from `equalsIgnoreCase` to `equals`; Result: No need to worry about cases for scheme check.
idelpivnitskiy
commented
Jun 17, 2024
.../http/http2/src/main/java/io/servicetalk/examples/http/http2/alpn/HttpUrlClientWithAlpn.java
Outdated
Show resolved
Hide resolved
bryce-anderson
approved these changes
Jun 17, 2024
.../http/http2/src/main/java/io/servicetalk/examples/http/http2/alpn/HttpUrlClientWithAlpn.java
Outdated
Show resolved
Hide resolved
Comment on lines
+103
to
+104
| // Use HttpRequestMetaData to access "https" constant used by Uri3986 class to optimize "equals" check to be a | ||
| // trivial reference check. |
There was a problem hiding this comment.
The selectClient was about 10% of CPU on the flame graph. There will be a few more follow-ups in this area, I'm just trying to isolate independent changes in separate PRs
idelpivnitskiy
commented
Jun 17, 2024
| @@ -44,7 +44,7 @@ interface SingleAddressInitializer<U, R> { | |||
| /** | |||
| * Configures the passed {@link SingleAddressHttpClientBuilder} for the given {@code scheme} and | |||
| * {@code address}. | |||
| * @param scheme The scheme parsed from the request URI. | |||
| * @param scheme The scheme parsed from a {@link HttpRequestMetaData#requestTarget() request URI} in lowercase. | |||
There was a problem hiding this comment.
What about this? Should we freeze this contract in javadoc or also leave us some flexibility?
The javadoc for HttpRequestMetaData#schem() already says it's always in lowercase.
There was a problem hiding this comment.
Decided to keep this PR purely internal. If you feel we need to update javadoc, I will open a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #2938 we made it guaranteed that
HttpRequestMetaData#scheme()result is always in lowercase. We can use that to simplify scheme checks insideDefaultMultiAddressUrlHttpClientBuilder.Modifications:
equalsIgnoreCasetoequals;httpsstring fromUri3986to speed upequalscheck;Result:
No need to worry about cases for scheme check.