loadbalancer-experimental: split ErrorClass into connection and request types #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st types Motivation: We have separate interfaces for the connection and request tracking in large part because we can't install our request tracker until we actually get a connection. However, they both use the same ErrorClass types. Modifications: - Split the error class types into two parts: those for connect path and those for request path. Result: What is the result of this change?
idelpivnitskiy
approved these changes
May 23, 2024
tkountis
approved these changes
May 24, 2024
mgodave
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have separate interfaces for the connection and request tracking
in large part because we can't install our request tracker until we
actually get a connection. However, they both use the same ErrorClass
types.
Modifications:
those for request path.