loadbalancer: move DefaultLoadBalancer to its own experimental module #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We want to start integrating with other packages but we can't without making some interfaces and types public. However, that means we're committing to the API and we don't want to do that yet. Modifications: Move the new load balancer code to its own experimental module. This is a strong signal to users that the API is in flux and should not be dependend upon yet.
tkountis
approved these changes
Jan 31, 2024
...lk-loadbalancer-experimental/src/test/java/io/servicetalk/loadbalancer/LoadBalancerTest.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to start integrating with other packages but we can't
without making some interfaces and types public. However, that
means we're committing to the API and we don't want to do that
yet.
Modifications:
Move the new load balancer code to its own experimental module.
This is a strong signal to users that the API is in flux and
should not be depended upon yet.
Reviewer Notes
Essentially everything here is a move/copy with a few exceptions:
now missing types that were moved to experimental and some
slight simplifications since abstraction is no longer needed.