Add validation for H1ProtocolConfigBuilder setters (#2792)

Motivation: `H1ProtocolConfigBuilder` does not validate incoming int parameters.
apple · Dec 21, 2023 · aeca73c · aeca73c
1 parent e3daaf3
commit aeca73c
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H1ProtocolConfigBuilder.java b/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H1ProtocolConfigBuilder.java
@@ -67,6 +67,9 @@ public H1ProtocolConfigBuilder headersFactory(final HttpHeadersFactory headersFa
      * @return {@code this}
      */
     public H1ProtocolConfigBuilder maxPipelinedRequests(final int maxPipelinedRequests) {
+        if (maxPipelinedRequests <= 0) {
+            throw new IllegalArgumentException("maxPipelinedRequests: " + maxPipelinedRequests + " (expected >0)");
+        }
         this.maxPipelinedRequests = maxPipelinedRequests;
         return this;
     }
@@ -83,6 +86,9 @@ public H1ProtocolConfigBuilder maxPipelinedRequests(final int maxPipelinedReques
      * @return {@code this}
      */
     public H1ProtocolConfigBuilder maxStartLineLength(final int maxStartLineLength) {
+        if (maxStartLineLength <= 0) {
+            throw new IllegalArgumentException("maxStartLineLength: " + maxStartLineLength + " (expected >0)");
+        }
         this.maxStartLineLength = maxStartLineLength;
         return this;
     }
@@ -100,6 +106,9 @@ public H1ProtocolConfigBuilder maxStartLineLength(final int maxStartLineLength)
      * @return {@code this}
      */
     public H1ProtocolConfigBuilder maxHeaderFieldLength(final int maxHeaderFieldLength) {
+        if (maxHeaderFieldLength <= 0) {
+            throw new IllegalArgumentException("maxHeaderFieldLength: " + maxHeaderFieldLength + " (expected >0)");
+        }
         this.maxHeaderFieldLength = maxHeaderFieldLength;
         return this;
     }
@@ -116,6 +125,10 @@ public H1ProtocolConfigBuilder maxHeaderFieldLength(final int maxHeaderFieldLeng
      * @return {@code this}
      */
     public H1ProtocolConfigBuilder headersEncodedSizeEstimate(final int headersEncodedSizeEstimate) {
+        if (headersEncodedSizeEstimate <= 0) {
+            throw new IllegalArgumentException("headersEncodedSizeEstimate: " + headersEncodedSizeEstimate +
+                    " (expected >0)");
+        }
         this.headersEncodedSizeEstimate = headersEncodedSizeEstimate;
         return this;
     }
@@ -130,6 +143,10 @@ public H1ProtocolConfigBuilder headersEncodedSizeEstimate(final int headersEncod
      * @return {@code this}
      */
     public H1ProtocolConfigBuilder trailersEncodedSizeEstimate(final int trailersEncodedSizeEstimate) {
+        if (trailersEncodedSizeEstimate <= 0) {
+            throw new IllegalArgumentException("trailersEncodedSizeEstimate: " + trailersEncodedSizeEstimate +
+                    " (expected >0)");
+        }
         this.trailersEncodedSizeEstimate = trailersEncodedSizeEstimate;
         return this;
     }