JSR305 integration for kotlinc
#920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
changed the title
jsr305 compat for kotlinckotlinc
sgammon
force-pushed
the
feat/kotlinc-opts
branch
2 times, most recently
from
417fa41 to
57d79ec
Compare
- feat: treat jsr305 as strict - feat: consider pkl's annotations for jsr305 compat Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon
force-pushed
the
feat/kotlinc-opts
branch
from
57d79ec to
16b2ed2
Compare
bioball
requested changes
Feb 3, 2025
There was a problem hiding this comment.
We already have some of these flags set, see
pkl/buildSrc/src/main/kotlin/pklAllProjects.gradle.kts
Lines 51 to 56 in 408242a
As far as I can tell, we don't need -Xjsr305=@org.pkl.core.util.Nullable:strict nor -Xjsr305=@org.pkl.core.util.Nonnull:strict, and we already get compiler errors on the Kotlin side.
For example:
diff --git a/pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt b/pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt
index 3ae23de..c72c201 100644
--- a/pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt
+++ b/pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt
@@ -93,6 +93,7 @@ constructor(
*/
override fun doRun() {
val builder = evaluatorBuilder()
+ println(builder.securityManager.checkReadResource(URI("foo:bar")))
try {
if (options.multipleFileOutputPath != null) {
writeMultipleFileOutput(builder)
Can you expand on javaParameters? How does this help debugging?
|
@bioball Good points. Let me do some testing to verify my assumptions and I'll get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applies
-Xjsr305=strictsupport for Pkl's own annotations,org.pkl.core.util.Nullableandorg.pkl.core.util.Nonnull. Java parameter names are retained in Kotlin bytecode, enabling smoother Java/Kotlin interop and debugging. Fixes deprecated/outdated use of Kotlin Gradle Plugin.