fix: downstream native-image builds
#914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
added a commit
to elide-dev/pkl
that referenced
this pull request
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon
added a commit
to elide-dev/pkl
that referenced
this pull request
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon
added a commit
to elide-dev/pkl
that referenced
this pull request
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon
added a commit
to elide-dev/pkl
that referenced
this pull request
Jan 29, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <sam@elide.dev>
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon
force-pushed
the
fix/nativeimage-build
branch
from
bf5057f to
5dbdbe9
Compare
|
@bioball It's mad about formatting. Fixed |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SVM (SubstrateVM) compile configuration classes must be included within the
clijar to prevent downstreamnative-imagebuilds from failing. Fat JARs cannot be used withnative-image, so these classes can still safely be excluded here.Fixes and closes #907
Changelog
clijar