Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #846

Merged
merged 38 commits into from
Dec 23, 2024
Merged

Spelling #846

merged 38 commits into from
Dec 23, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 16, 2024

This PR corrects misspellings identified by the check-spelling action (which is an evolution of the script I used ages ago when I first made a PR here...).

The misspellings have been reported at https://github.com/jsoref/pkl/actions/runs/12355506259#summary-34479284401

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/pkl/actions/runs/12355506467#summary-34479285104

jsoref
jsoref commented Dec 16, 2024
View reviewed changes
docs/modules/release-notes/pages/0.26.adoc
@@ -12,7 +12,7 @@ This release brings Windows support, improvements to controlling how Pkl talks o

The next release (0.27) is scheduled for October 10th, 2024.

Please send feedback and questions to https://github.com/apple/pkl/discussions[GitHub Discussions], or submit an issue on https://github.com/apple/pkl/issues/new[Github]. +
Please send feedback and questions to https://github.com/apple/pkl/discussions[GitHub Discussions], or submit an issue on https://github.com/apple/pkl/issues/new[GitHub]. +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like changing changelogs. I'm happy to drop this or anything else.

pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt
@@ -1313,7 +1313,7 @@ result = someLib.x
val options =
CliEvaluatorOptions(
CliBaseOptions(
sourceModules = listOf(URI("package://localhost:1/birds@0.5.0#/catalog/Ostritch.pkl")),
sourceModules = listOf(URI("package://localhost:1/birds@0.5.0#/catalog/Ostrich.pkl")),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is a test file, and that this file imagines being versioned but I don't see any reason not to fix the spelling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine to change it. You'll need to update our tests, though. Take a look through the failures here to know what replacements you need to make:

https://app.circleci.com/pipelines/github/apple/pkl/1716/workflows/d5cfc639-82e2-49b6-b32a-a3d044090207/jobs/9850/tests

pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
@@ -333,7 +333,7 @@ public byte[] getBytes(
throw fileIsADirectory();
}
var entries = cachedEntries.get(packageUri);
// need to normalize here but not in `doListElments` nor `doHasElement` because
// need to normalize here but not in `doListElements` nor `doHasElement` because
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same grammar rule that had me rewrite a not/nor above complained here, but I didn't have the energy to propose a rewrite, it would be something like:

  // need to normalize unlike `doListElements` and `doHasElement` which call `TreePathElement.getElement` which does normalization.

pkl-core/src/test/files/LanguageSnippetTests/input/api/pcfRenderer1.pkl Show resolved Hide resolved
pkl-core/src/test/files/LanguageSnippetTests/input/api/pcfRenderer1.pkl
"""
}
// multiline string that is an element
"""
Flistone
Flintstone
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, there wasn't any particularly obvious reason to use Flistone instead (notably different from the above or the expected spelling)

pkl-core/src/test/files/LanguageSnippetTests/input/classes/class3.pkl
@@ -8,5 +8,5 @@ class Person {
person = new Person {
name = "Pigeon"
// typo
adress = "Howdy St."
address_ = "Howdy St."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general preference is to add a _ to a token to make it not match -- it's equivalent to a typo for anything that's parsing for a perfect match, but it doesn't upset dictionary based checks which reduces the number of false positives that a spell-checking tool needs to tolerate. (I didn't change zipp in a similar instance, but I'd be more than happy to do so.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine; the spelling error is orthogonal to what this test is about anyways.

pkl-core/src/test/files/LanguageSnippetTests/input/packages/badRead8.error.pkl
@@ -1 +1 @@
res = import("package://localhost:0/badImportsWithinPackage@1.0.0#/unknownDependencyReaad.pkl")
res = import("package://localhost:0/badImportsWithinPackage@1.0.0#/unknownDependencyRead.pkl")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike Ostritch, these files don't seem to exist (which more or less makes sense given what they're testing) so there doesn't seem to be something to rename...

bioball
bioball approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for taking the time to do this! This all looks really good.

LGTM, pending test failures.

You can reproduce these errors locally by running ./gradlew check.

pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt
@@ -1313,7 +1313,7 @@ result = someLib.x
val options =
CliEvaluatorOptions(
CliBaseOptions(
sourceModules = listOf(URI("package://localhost:1/birds@0.5.0#/catalog/Ostritch.pkl")),
sourceModules = listOf(URI("package://localhost:1/birds@0.5.0#/catalog/Ostrich.pkl")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine to change it. You'll need to update our tests, though. Take a look through the failures here to know what replacements you need to make:

https://app.circleci.com/pipelines/github/apple/pkl/1716/workflows/d5cfc639-82e2-49b6-b32a-a3d044090207/jobs/9850/tests

@jsoref
Copy link
Contributor Author

jsoref commented Dec 17, 2024

I tried using gradlew and it did not like me:

gradlew 
% ./gradlew check
Starting a Gradle Daemon (subsequent builds will be faster)
Type-safe project accessors is an incubating feature.

> Task :pkl-config-kotlin:generateTestConfigClasses FAILED
Exception in thread "main" java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)'
        at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
        at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
        at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
        at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
        at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:578)
        at java.base/java.lang.Class.forName(Class.java:557)
        at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
        at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
        at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
        at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
        at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
        at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
        at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
        at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
        at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
        at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
        at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
        at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
        at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
        at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
        at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
        at org.pkl.core.EvaluatorImpl.<init>(EvaluatorImpl.java:92)
        at org.pkl.core.EvaluatorBuilder.build(EvaluatorBuilder.java:530)
        at org.pkl.codegen.kotlin.CliKotlinCodeGenerator.doRun(CliKotlinCodeGenerator.kt:34)
        at org.pkl.commons.cli.CliCommand.run(CliCommand.kt:45)
        at org.pkl.codegen.kotlin.PklKotlinCodegenCommand.run(Main.kt:109)
        at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:198)
        at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:18)
        at com.github.ajalt.clikt.core.CliktCommand.parse(CliktCommand.kt:400)
        at com.github.ajalt.clikt.core.CliktCommand.parse$default(CliktCommand.kt:397)
        at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:415)
        at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:440)
        at org.pkl.codegen.kotlin.Main$main$1.invoke(Main.kt:34)
        at org.pkl.codegen.kotlin.Main$main$1.invoke(Main.kt:34)
        at org.pkl.commons.cli.CliMainKt.cliMain(CliMain.kt:33)
        at org.pkl.codegen.kotlin.Main.main(Main.kt:34)

> Task :pkl-server:test FAILED

There were failing tests. See the report at: file:///Users/jsoref/code/apple/pkl/pkl-server/build/reports/tests/test/index.html

> Task :docs:test FAILED

modules > initializationError FAILED
    org.junit.platform.commons.JUnitException: TestEngine with ID 'pkl-doc-tests' failed to execute tests
        at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:113)
        at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
        at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
        at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
        at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
        at app//org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
        at app//org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
        at app//org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
        at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
        at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
        at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
        at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
        at java.base@23.0.1/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base@23.0.1/java.lang.reflect.Method.invoke(Method.java:580)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
        at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
        at jdk.proxy1/jdk.proxy1.$Proxy4.stop(Unknown Source)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
        at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
        at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
        at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
        at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
        at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

        Caused by:
        java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)'
            at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
            at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
            at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
            at java.base/java.lang.Class.forName0(Native Method)
            at java.base/java.lang.Class.forName(Class.java:578)
            at java.base/java.lang.Class.forName(Class.java:557)
            at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
            at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
            at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
            at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
            at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
            at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
            at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
            at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
            at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
            at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
            at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
            at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
            at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
            at org.pkl.core.runtime.BaseModule.<clinit>(BaseModule.java:24)
            at org.pkl.core.repl.ReplServer.<init>(ReplServer.java:88)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:80)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:37)
            at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
            ... 27 more

CoreEvaluatorExample > usage() FAILED
    java.lang.NoClassDefFoundError: Could not initialize class org.pkl.core.runtime.VmUtils
        at org.pkl.core.EvaluatorImpl.<init>(EvaluatorImpl.java:92)
        at org.pkl.core.EvaluatorBuilder.build(EvaluatorBuilder.java:530)
        at org.pkl.core.Evaluator.preconfigured(Evaluator.java:37)
        at CoreEvaluatorExample.usage(CoreEvaluatorExample.java:17)

        Caused by:
        java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)' [in thread "Test worker"]
            at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
            at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
            at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
            at java.base/java.lang.Class.forName0(Native Method)
            at java.base/java.lang.Class.forName(Class.java:578)
            at java.base/java.lang.Class.forName(Class.java:557)
            at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
            at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
            at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
            at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
            at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
            at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
            at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
            at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
            at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
            at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
            at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
            at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
            at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
            at org.pkl.core.runtime.BaseModule.<clinit>(BaseModule.java:24)
            at org.pkl.core.repl.ReplServer.<init>(ReplServer.java:88)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:80)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:37)
            at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
            at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
            at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
            at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
            at java.base/java.lang.reflect.Method.invoke(Method.java:580)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
            at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
            at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
            at jdk.proxy1/jdk.proxy1.$Proxy4.stop(Unknown Source)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
            at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

JavaConfigExample > usage() FAILED
    java.lang.NoClassDefFoundError: Could not initialize class org.pkl.core.runtime.VmUtils
        at org.pkl.core.EvaluatorImpl.<init>(EvaluatorImpl.java:92)
        at org.pkl.core.EvaluatorBuilder.build(EvaluatorBuilder.java:530)
        at org.pkl.config.java.ConfigEvaluatorBuilder.build(ConfigEvaluatorBuilder.java:321)
        at org.pkl.config.java.ConfigEvaluator.preconfigured(ConfigEvaluator.java:30)
        at JavaConfigExample.usage(JavaConfigExample.java:14)

        Caused by:
        java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)' [in thread "Test worker"]
            at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
            at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
            at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
            at java.base/java.lang.Class.forName0(Native Method)
            at java.base/java.lang.Class.forName(Class.java:578)
            at java.base/java.lang.Class.forName(Class.java:557)
            at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
            at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
            at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
            at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
            at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
            at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
            at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
            at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
            at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
            at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
            at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
            at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
            at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
            at org.pkl.core.runtime.BaseModule.<clinit>(BaseModule.java:24)
            at org.pkl.core.repl.ReplServer.<init>(ReplServer.java:88)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:80)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:37)
            at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
            at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
            at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
            at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
            at java.base/java.lang.reflect.Method.invoke(Method.java:580)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
            at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
            at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
            at jdk.proxy1/jdk.proxy1.$Proxy4.stop(Unknown Source)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
            at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

KotlinConfigExample > nullable() FAILED
    java.lang.NoClassDefFoundError: Could not initialize class org.pkl.core.runtime.VmUtils
        at org.pkl.core.EvaluatorImpl.<init>(EvaluatorImpl.java:92)
        at org.pkl.core.EvaluatorBuilder.build(EvaluatorBuilder.java:530)
        at org.pkl.config.java.ConfigEvaluatorBuilder.build(ConfigEvaluatorBuilder.java:321)
        at org.pkl.config.java.ConfigEvaluator.preconfigured(ConfigEvaluator.java:30)
        at KotlinConfigExample.nullable(KotlinConfigExample.kt:27)

        Caused by:
        java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)' [in thread "Test worker"]
            at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
            at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
            at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
            at java.base/java.lang.Class.forName0(Native Method)
            at java.base/java.lang.Class.forName(Class.java:578)
            at java.base/java.lang.Class.forName(Class.java:557)
            at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
            at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
            at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
            at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
            at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
            at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
            at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
            at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
            at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
            at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
            at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
            at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
            at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
            at org.pkl.core.runtime.BaseModule.<clinit>(BaseModule.java:24)
            at org.pkl.core.repl.ReplServer.<init>(ReplServer.java:88)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:80)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:37)
            at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
            at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
            at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
            at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
            at java.base/java.lang.reflect.Method.invoke(Method.java:580)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
            at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
            at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
            at jdk.proxy1/jdk.proxy1.$Proxy4.stop(Unknown Source)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
            at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

KotlinConfigExample > usage() FAILED
    java.lang.NoClassDefFoundError: Could not initialize class org.pkl.core.runtime.VmUtils
        at org.pkl.core.EvaluatorImpl.<init>(EvaluatorImpl.java:92)
        at org.pkl.core.EvaluatorBuilder.build(EvaluatorBuilder.java:530)
        at org.pkl.config.java.ConfigEvaluatorBuilder.build(ConfigEvaluatorBuilder.java:321)
        at org.pkl.config.java.ConfigEvaluator.preconfigured(ConfigEvaluator.java:30)
        at KotlinConfigExample.usage(KotlinConfigExample.kt:14)

        Caused by:
        java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)' [in thread "Test worker"]
            at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
            at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
            at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
            at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
            at java.base/java.lang.Class.forName0(Native Method)
            at java.base/java.lang.Class.forName(Class.java:578)
            at java.base/java.lang.Class.forName(Class.java:557)
            at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
            at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
            at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
            at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
            at com.oracle.truffle.polyglot.PolyglotValueDispatch.<clinit>(PolyglotValueDispatch.java:170)
            at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:169)
            at org.graalvm.polyglot.impl.AbstractPolyglotImpl.setConstructors(AbstractPolyglotImpl.java:288)
            at org.graalvm.polyglot.Engine$1.loadAndValidateProviders(Engine.java:1107)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1067)
            at org.graalvm.polyglot.Engine$1.run(Engine.java:1061)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
            at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1061)
            at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:143)
            at org.graalvm.polyglot.Engine.getImpl(Engine.java:367)
            at org.graalvm.polyglot.Engine$Builder.build(Engine.java:665)
            at org.pkl.core.runtime.VmUtils.<clinit>(VmUtils.java:73)
            at org.pkl.core.runtime.BaseModule.<clinit>(BaseModule.java:24)
            at org.pkl.core.repl.ReplServer.<init>(ReplServer.java:88)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:80)
            at DocSnippetTestsEngine.createExecutionContext(DocSnippetTests.kt:37)
            at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
            at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
            at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
            at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
            at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
            at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
            at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
            at java.base/java.lang.reflect.Method.invoke(Method.java:580)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
            at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
            at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
            at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
            at jdk.proxy1/jdk.proxy1.$Proxy4.stop(Unknown Source)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
            at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
            at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
            at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
            at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

There were failing tests. See the report at: file:///Users/jsoref/code/apple/pkl/docs/build/reports/tests/test/index.html

5 tests completed, 5 failed
[Incubating] Problems report is available at: file:///Users/jsoref/code/apple/pkl/build/reports/problems/problems-report.html

FAILURE: Build completed with 3 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':pkl-config-kotlin:generateTestConfigClasses'.
> Process 'command '/Library/Java/JavaVirtualMachines/amazon-corretto-23.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':pkl-server:test'.
> There were failing tests. See the report at: file:///Users/jsoref/code/apple/pkl/pkl-server/build/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.
==============================================================================

3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':docs:test'.
> There were failing tests. See the report at: file:///Users/jsoref/code/apple/pkl/docs/build/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.
==============================================================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.11/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 31s
207 actionable tasks: 33 executed, 2 from cache, 172 up-to-date
java_home 
jsoref@jsoref-mbp pkl % /usr/libexec/java_home -V
Matching Java Virtual Machines (13):
    23.0.1 (arm64) "Amazon.com Inc." - "Amazon Corretto 23" /Library/Java/JavaVirtualMachines/amazon-corretto-23.jdk/Contents/Home
    23.0.1 (arm64) "Eclipse Adoptium" - "OpenJDK 23.0.1" /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
    19.0.2 (arm64) "Amazon.com Inc." - "Amazon Corretto 19" /Library/Java/JavaVirtualMachines/amazon-corretto-19.jdk/Contents/Home
    19.0.2 (arm64) "Eclipse Adoptium" - "OpenJDK 19.0.2" /Library/Java/JavaVirtualMachines/temurin-19.jdk/Contents/Home
    16.0.1 (x86_64) "AdoptOpenJDK" - "AdoptOpenJDK 16" /Library/Java/JavaVirtualMachines/adoptopenjdk-16.jdk/Contents/Home
    11.0.25 (arm64) "Eclipse Adoptium" - "OpenJDK 11.0.25" /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
    11.0.14.1 (x86_64) "Azul Systems, Inc." - "Zulu 11.54.25" /Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
    11.0.11 (x86_64) "AdoptOpenJDK" - "AdoptOpenJDK (OpenJ9) 11" /Library/Java/JavaVirtualMachines/adoptopenjdk-11-openj9.jdk/Contents/Home
    11.0.1 (x86_64) "Oracle Corporation" - "OpenJDK 11.0.1" /Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home
    1.8.0_322 (x86_64) "Amazon" - "Amazon Corretto 8" /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home
    1.8.0_322 (x86_64) "Azul Systems, Inc." - "Zulu 8.60.0.21" /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home
    1.8.0_241 (x86_64) "Oracle Corporation" - "Java SE 8" /Library/Java/JavaVirtualMachines/jdk1.8.0_241.jdk/Contents/Home
    1.7.0_332 (x86_64) "Azul Systems, Inc." - "Zulu 7.52.0.11" /Library/Java/JavaVirtualMachines/zulu-7.jdk/Contents/Home
/Library/Java/JavaVirtualMachines/amazon-corretto-23.jdk/Contents/Home
Java version 
openjdk version "23.0.1" 2024-10-15
OpenJDK Runtime Environment Corretto-23.0.1.8.1 (build 23.0.1+8-FR)
OpenJDK 64-Bit Server VM Corretto-23.0.1.8.1 (build 23.0.1+8-FR, mixed mode, sharing)

@HT154
Copy link
Contributor

HT154 commented Dec 17, 2024

Try installing/selecting a JDK 17 version. I'm not sure of the exact version range that works, but I know that Pkl won't build on JDK 22+.

@bioball
Copy link
Contributor

bioball commented Dec 17, 2024 •
edited
Loading

Jenv is a pretty nice tool to help switch Java versions: https://www.jenv.be

You'll still need to install the JDK yourself, then point jenv at the install path.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 17, 2024

I have plenty of other versions available, and I have a script to switch, that said:

pkl/DEVELOPMENT.adoc

Line 10 in 6bd8e28

. (mandatory) Install {uri-jdk}[OpenJDK 17] or higher

Says "or higher", so I don't think it's unreasonable for me to expect it to work.

@bioball
Copy link
Contributor

bioball commented Dec 17, 2024

Ah, that used to be true, before JDK22 came out :D

Pkl currently requires JDK 17 - 21 (inclusive)

#848 to fix.

@bioball
Copy link
Contributor

bioball commented Dec 23, 2024

I will go ahead and fix up the tests to take this to the finish line.

jsoref added 20 commits December 23, 2024 12:08
@jsoref @bioball
spelling: additional
bc82028 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: address
fce25fe 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: amending
02cbabc 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: analyze
220cca3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: caching
f2242d6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: cannot
ef32bf1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: character
f15e462 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: class
cbcab7c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: codegen
a788119 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: constructor
fbb4362 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: convenience
e64e347 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: current
d806125 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: delimiters
eb8bc88 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: dependencies
de13f7f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: dependency
d1d8fb5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: determine
f8a392c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: elements
9d2255e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: empty
b65b43f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: erroneously
edc1837 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: evaluates
6954128 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref and others added 18 commits December 23, 2024 12:08
@jsoref @bioball
spelling: extended
2917ce1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: flintstone
70ee1a5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: github
29a3938 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: greater
d64169d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: neither-nor
f60f0d0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: nonexistent
5f3b55a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: occurred
a326200 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: ostrich
0b4d2a2 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: parameter
7dbb355 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: parsed
4097a39 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: privileges
d59ab8c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: read
9339f93 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: remaining
3156fd1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: the
0eb1659 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: this
d6542a5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: unnecessarily
93c1ff4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @bioball
spelling: wildcard
85b40d2 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@bioball
Fix snippet test errors
29a9a0d
@bioball bioball merged commit d9c65d4 into apple:main Dec 23, 2024
5 checks passed
@jsoref jsoref deleted the spelling branch December 23, 2024 23:05
@bioball bioball added this to the Pkl 0.28.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bioball bioball bioball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pkl 0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @HT154 @bioball