Review suggestions

pkl-core/src/main/java/org/pkl/core/stdlib/math/MathNodes.java

@@ -309,6 +309,15 @@ protected double eval(VmTyped self, long x, long y) {
     protected double eval(VmTyped self, long x, double y) {
       return StrictMath.atan2(x, y);
     }
+
+    @Specialization
+    protected double eval(VmTyped self, double x, double y) {
+      return StrictMath.atan2(x, y);
+    }
+    @Specialization
+    protected double eval(VmTyped self, double x, long y) {
+      return StrictMath.atan2(x, y);
+    }
   }
 
   public abstract static class gcd extends ExternalMethod2Node {

pkl-core/src/test/files/LanguageSnippetTests/input/api/mathModule.pkl

@@ -132,6 +132,9 @@ examples {
 
   ["atan2"] {
     math.atan2(4, -3)
+    math.atan2(4.5, -3.5)
+    math.atan2(4.5, -3)
+    math.atan2(4, 3.5)
   }
 
   ["gcd"] {
@@ -193,3 +196,10 @@ examples {
     math.min(Infinity, -Infinity)
   }
 }
+
+facts {
+  ["atan2"] {
+    math.atan2(1, 0) == math.pi / 2
+    math.atan2(0, -1) == math.pi
+  }
+}

stdlib/math.pkl

@@ -145,9 +145,10 @@ external function acos(x: Number): Float
 /// [1]: https://en.wikipedia.org/wiki/Inverse_trigonometric_functions
 external function atan(x: Number): Float
 
-/// Returns the [4-quadrant inverse tangent][1] of [x] and [y].
+/// Returns the [2-argument arctangent][1] of [x] and [y].
 ///
 /// [1]: https://en.wikipedia.org/wiki/Atan2
+@Since { version = "0.28.0" }
 external function atan2(x: Number, y: Number): Float
 
 /// Returns the [greatest common divisor][1] of [x] and [y].