Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert org.pkl.core POJOs to record classes #808

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Convert org.pkl.core POJOs to record classes #808

merged 2 commits into from
Nov 13, 2024

Conversation

KushalP
Copy link
Contributor

@KushalP KushalP commented Nov 13, 2024

No description provided.

@KushalP KushalP force-pushed the org.pkl.core-use-record branch from 469a48a to 48e69e7 Compare November 13, 2024 16:25
holzensp
holzensp approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@holzensp holzensp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convenient that most already had getters named in record style

pkl-core/src/main/java/org/pkl/core/Platform.java Outdated Show resolved Hide resolved
@KushalP KushalP force-pushed the org.pkl.core-use-record branch from 48e69e7 to ad61ac9 Compare November 13, 2024 17:31
bioball
bioball approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the deleted line count!

@bioball bioball merged commit 9a27616 into apple:main Nov 13, 2024
5 checks passed
@KushalP KushalP deleted the org.pkl.core-use-record branch November 14, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bioball bioball bioball approved these changes

@holzensp holzensp holzensp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KushalP @holzensp @bioball