Eagerly check function arguments when called from inside iterable #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigates an issue where lazy mappings and listings widen an existing bug. This is a follow-up to apple#752.
bioball
commented
Nov 4, 2024
| * <p>If {@code value} is conforming, sets {@code slot} to {@code value}. Otherwise, throws a | ||
| * {@link VmTypeMismatchException}. | ||
| */ | ||
| public abstract Object executeEagerlyAndSet(VirtualFrame frame, Object value); |
There was a problem hiding this comment.
This method is used when checking a function's arguments.
This node:
function foo(bar: Listing<Int>) =
^^^^^^^^^^^^
We need to add the method because we need to capture the logic of:
- Run an eager typecheck
- Set that value on the frame.
bioball
force-pushed
the
eager-check-iterables
branch
from
f9e2984 to
a23b8f8
Compare
holzensp
approved these changes
Nov 4, 2024
| @@ -36,6 +36,7 @@ | |||
| import org.pkl.core.runtime.VmFunction; | |||
|
|
|||
| /** A virtual method call. */ | |||
| @SuppressWarnings("DuplicatedCode") | |||
There was a problem hiding this comment.
What does this overlap with?
There was a problem hiding this comment.
The various specializations here. Adding just one more line to each method triggered the duplicate code detection warning.
stackoverflow
approved these changes
Nov 5, 2024
| @@ -44,7 +44,7 @@ public final class FunctionNode extends RegularMemberNode { | |||
| // For VmObject receivers, the owner is the same as or an ancestor of the receiver. | |||
| // For other receivers, the owner is the prototype of the receiver's class. | |||
| // The chain of enclosing owners forms a function/property's lexical scope. | |||
| private static final int IMPLICIT_PARAM_COUNT = 2; | |||
| private static final int IMPLICIT_PARAM_COUNT = 3; | |||
There was a problem hiding this comment.
We should update the docs which still state there are "two implicit arguments".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates an issue where lazy mappings and listings widen an existing bug.
This is a follow-up to #752.
Ideally, when we fix the scoping bug, we also revert this commit.